Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 117693002: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed)

Created:
7 years ago by Charlie Reis
Modified:
7 years ago
Reviewers:
jam, nasko
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. We still only have a RFHM for the main frame and not subframes, unless the --site-per-process flag is passed. To external callers, RFHM is still effectively swapping RenderViewHosts. RenderFrameHosts now indirectly keep their RenderViewHosts alive. Second attempt, after fixing memory leak from http://crrev.com/241151. R=nasko@chromium.org TBR=jam@chromium.org BUG=314791 TEST=No visible behavior change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241423

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+951 lines, -690 lines) Patch
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 5 chunks +39 lines, -16 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 6 chunks +81 lines, -31 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 5 chunks +21 lines, -42 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 3 chunks +24 lines, -14 lines 0 comments Download
M content/browser/frame_host/frame_tree_unittest.cc View 5 chunks +35 lines, -67 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 6 chunks +15 lines, -19 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +7 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 9 chunks +82 lines, -44 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 31 chunks +373 lines, -241 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 26 chunks +140 lines, -114 lines 0 comments Download
M content/browser/renderer_host/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 6 chunks +4 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 8 chunks +4 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 5 chunks +13 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/test/test_render_frame_host.cc View 2 chunks +10 lines, -1 line 0 comments Download
M content/test/test_render_view_host.h View 4 chunks +11 lines, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/test/test_render_view_host_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Argh! Somehow my git rebase caused https://codereview.chromium.org/108483008/ to commit *only* the memory leak fix and ...
7 years ago (2013-12-17 22:40:21 UTC) #1
Charlie Reis
Just fixed two merge conflicts with John's http://crrev.com/241306.
7 years ago (2013-12-17 23:06:39 UTC) #2
nasko
LGTM
7 years ago (2013-12-17 23:19:36 UTC) #3
Charlie Reis
7 years ago (2013-12-18 00:07:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r241423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698