Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1176903002: Added logging of the name of the test before it starts (Closed)

Created:
4 years, 10 months ago by Sergiy Byelozyorov
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added logging of the name of the test before it starts R=machenbach@chromium.org BUG=498689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196872

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergiy Byelozyorov
4 years, 10 months ago (2015-06-10 13:28:20 UTC) #1
Michael Achenbach
lgtm
4 years, 10 months ago (2015-06-10 13:31:30 UTC) #2
Michael Achenbach
https://codereview.chromium.org/1176903002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py File Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py (right): https://codereview.chromium.org/1176903002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py#newcode286 Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:286: _log.debug("%s %s started:" % (self._name, test_input.test_name)) nit: Maybe remove ...
4 years, 10 months ago (2015-06-10 13:32:46 UTC) #3
Sergiy Byelozyorov
https://codereview.chromium.org/1176903002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py File Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py (right): https://codereview.chromium.org/1176903002/diff/1/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py#newcode286 Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:286: _log.debug("%s %s started:" % (self._name, test_input.test_name)) On 2015/06/10 13:32:46, ...
4 years, 10 months ago (2015-06-10 13:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176903002/20001
4 years, 10 months ago (2015-06-10 13:33:20 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 14:35:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196872

Powered by Google App Engine
This is Rietveld 408576698