Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1176863002: Revert of Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #1 id:1 of https://codereview.chromium.org/1163373005/) Reason for revert: All build problems had other causes. Original issue's description: > Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #3 id:40001 of https://codereview.chromium.org/1171943002/) > > Reason for revert: > might break stuff > > Original issue's description: > > [test] Refactoring - Use subject/observer pattern for progress indicators. > > > > This should prevent bugs caused by missing super calls in > > overridden methods. The assumption is that methods of > > different indicators are independent. > > > > Committed: https://crrev.com/fbe973ff1722a6158a5b2babce9c1a32d26a1d3b > > Cr-Commit-Position: refs/heads/master@{#28866} > > TBR=jkummerow@chromium.org,tandrii@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/2a3962d9d2a7415378811f4d56522531332d5a3e > Cr-Commit-Position: refs/heads/master@{#28869} TBR=jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1a511b0e38f57431494e8a00a4ae92fcede9e02f Cr-Commit-Position: refs/heads/master@{#28901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M tools/run-tests.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/testrunner/local/progress.py View 7 chunks +34 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of [test] Refactoring - Use subject/observer pattern for progress indicators.
5 years, 6 months ago (2015-06-10 09:42:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176863002/1
5 years, 6 months ago (2015-06-10 09:42:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 09:42:28 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 09:42:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a511b0e38f57431494e8a00a4ae92fcede9e02f
Cr-Commit-Position: refs/heads/master@{#28901}

Powered by Google App Engine
This is Rietveld 408576698