Source/web/WebRemoteFrameImpl.cpp - Issue 1176843006: Move window.close implementation to DOMWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 1176843006: Move window.close implementation to DOMWindow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove resetting of the main view. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index b8d53c8328172c5f4b9e7330bac87cb369af1030..89f7bd89fe8aedcbe8cac8c320130a55aba7a676 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -332,7 +332,8 @@ void WebRemoteFrameImpl::loadHTMLString(

void WebRemoteFrameImpl::stopLoading()

{

- ASSERT_NOT_REACHED();

+ // TODO(dcheng,japhet): Calling this method should stop loads

+ // in all subframes, both remote and local.

}

WebDataSource* WebRemoteFrameImpl::provisionalDataSource() const

« no previous file with comments | « Source/web/RemoteFrameClientImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »