Source/web/ChromeClientImpl.cpp - Issue 1176843006: Move window.close implementation to DOMWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 1176843006: Move window.close implementation to DOMWindow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase and move backForwardHistory to FrameClient. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index bfb4806685ed4401ed5d57bd63d07407fd239e1b..d135933c64d239940bbf7a7ff6e88354ebf94ec8 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -400,7 +400,8 @@ void ChromeClientImpl::closeWindowSoon()

Page::ordinaryPages().remove(m_webView->page());

// Make sure that all loading is stopped. Ensures that JS stops executing!

- m_webView->mainFrame()->stopLoading();

+ if (m_webView->mainFrame()->isWebLocalFrame())

dcheng 2015/06/17 23:39:50 TODO this?

nasko 2015/06/19 13:23:22 Actually, the method is available on WebRemoteFram

+ m_webView->mainFrame()->stopLoading();

if (m_webView->client())

m_webView->client()->closeWidgetSoon();