Move window.close implementation to DOMWindow

Source/core/frame/RemoteFrame.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/frame/RemoteFrame.h"
 
 #include "bindings/core/v8/WindowProxy.h"
 #include "bindings/core/v8/WindowProxyManager.h"
 #include "core/dom/RemoteSecurityContext.h"
@@ skipping 132 matching lines @@
     RefPtrWillBeRawPtr<RemoteFrameView> view = RemoteFrameView::create(this);
     setView(view);
 
     if (ownerLayoutObject()) {
         HTMLFrameOwnerElement* owner = deprecatedLocalOwner();
         ASSERT(owner);
         owner->setWidget(view);
     }
 }
 
+void RemoteFrame::close()
+{
+    // window.close only makes sense on a top-level frame.
+    if (!tree().parent())
+        remoteFrameClient()->close();

[dcheng, 2015/06/10 20:10:41]

LocalDOMWindow::close() has a bunch of other stuff. It seems like at least some
of these other things are relevant for RemoteDOMWindow too, right?

For example, respecting the "allow scripts to close windows" setting, setting
m_windowIsClosing, etc.

Also, can we just use ChromeClient::closeWindowSoon()?

[nasko, 2015/06/11 00:04:39]

I've added those to RemoteDOMWindow.
 
I'd rather not, as it goes over to the widget and for remote frames we don't
have a widget on the content/ side, just a proxy.

[dcheng, 2015/06/11 02:00:06]

Well... but we can change that to do what we need... the important part is
ChromeClient lets us get to the WebViewClient.

Logically, there's no real difference between closing a LocalDOMWindow and a
RemoteDOMWindow. Closing either one ultimately still requires the browser to do
things for us.

And if we do use ChromeClient::closeWindowSoon() here, I think we might be able
to just move the entire function up into DOMWindow, eliminating the duplicated
checks, etc.

+}
+
 RemoteFrameClient* RemoteFrame::remoteFrameClient() const
 {
     return static_cast<RemoteFrameClient*>(client());
 }
 
 void RemoteFrame::setRemotePlatformLayer(WebLayer* layer)
 {
     if (m_remotePlatformLayer)
         GraphicsLayer::unregisterContentsLayer(m_remotePlatformLayer);
     m_remotePlatformLayer = layer;
     if (m_remotePlatformLayer)
         GraphicsLayer::registerContentsLayer(layer);
 
     ASSERT(owner());
     toHTMLFrameOwnerElement(owner())->setNeedsCompositingUpdate();
     if (LayoutPart* layoutObject = ownerLayoutObject())
         layoutObject->layer()->updateSelfPaintingLayer();
 }
 
 } // namespace blink