Issue 117683002: Show the Mac app launcher window with a spinner while loading Chrome.

Issue 117683002: Show the Mac app launcher window with a spinner while loading Chrome. (Closed)

Created:
7 years ago by tapted

Modified:
6 years, 11 months ago

Reviewers:
jackhou1

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Show the Mac app launcher window with a spinner while loading Chrome. Currently showing the app launcher window on a Chrome cold start is blocked by profile loading and other browser startup tasks, which can take a while. This CL allows the Mac app launcher window to be shown empty, with a progress spinner. Once the the profile has finished loading, the window is populated with a subtle icon fade-in animation. Screenshot at http://crbug.com/335433#c1 BUG=178260, 335433 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245472

Patch Set 1 #

Patch Set 2 : fix obscurities #

Patch Set 3 : fix more stray profile loadings #

Patch Set 4 : base of master, for bots #

Patch Set 5 : rebase, ensure no startup flows regress #

Total comments: 5

Patch Set 6 : typos #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -11 lines)			Patch
M	chrome/browser/ui/app_list/app_list_service_mac.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_service_mac.mm	View	1 2 3 4 5	8 chunks	+45 lines, -10 lines	0 comments	Download
M	ui/app_list/cocoa/app_list_view_controller.h	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/app_list/cocoa/app_list_view_controller.mm	View	1 2	3 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tapted

Jack, could you take a look? https://codereview.chromium.org/117683002/diff/260001/chrome/browser/ui/app_list/app_list_service_mac.mm File chrome/browser/ui/app_list/app_list_service_mac.mm (left): https://codereview.chromium.org/117683002/diff/260001/chrome/browser/ui/app_list/app_list_service_mac.mm#oldcode377 chrome/browser/ui/app_list/app_list_service_mac.mm:377: [[window_controller_ appListViewController] searchBoxModel] ...

6 years, 11 months ago (2014-01-17 04:42:39 UTC) #1

jackhou1

lgtm https://codereview.chromium.org/117683002/diff/260001/chrome/browser/ui/app_list/app_list_service_mac.mm File chrome/browser/ui/app_list/app_list_service_mac.mm (right): https://codereview.chromium.org/117683002/diff/260001/chrome/browser/ui/app_list/app_list_service_mac.mm#newcode375 chrome/browser/ui/app_list/app_list_service_mac.mm:375: // lanuches will always have --silent-launch. lanuches -> ...

6 years, 11 months ago (2014-01-17 06:10:53 UTC) #2

tapted

Thanks Jack! https://codereview.chromium.org/117683002/diff/260001/chrome/browser/ui/app_list/app_list_service_mac.mm File chrome/browser/ui/app_list/app_list_service_mac.mm (right): https://codereview.chromium.org/117683002/diff/260001/chrome/browser/ui/app_list/app_list_service_mac.mm#newcode375 chrome/browser/ui/app_list/app_list_service_mac.mm:375: // lanuches will always have --silent-launch. On ...

6 years, 11 months ago (2014-01-17 06:21:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/117683002/370001

6 years, 11 months ago (2014-01-17 06:21:40 UTC) #4

Message was sent while issue was closed.

Change committed as 245472

Expand Messages | Collapse Messages