Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1176823002: Remove ChromeNativeAppWindowViews::is_fullscreen_. (Closed)

Created:
5 years, 6 months ago by jackhou1
Modified:
5 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeNativeAppWindowViews::is_fullscreen_. This is not necessary as it should always be equivalent to Widget::IsFullscreen. BUG=None Committed: https://crrev.com/6063e8bb90fec5e53b5b1187de367b9d3adb68b9 Cr-Commit-Position: refs/heads/master@{#333892}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jackhou1
5 years, 6 months ago (2015-06-10 06:40:41 UTC) #2
tapted
I usually see BUG=None rather than =0 (or no BUG= line). otherwise lgtm https://codereview.chromium.org/1176823002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc File ...
5 years, 6 months ago (2015-06-10 11:07:50 UTC) #3
jackhou1
https://codereview.chromium.org/1176823002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (right): https://codereview.chromium.org/1176823002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc#newcode337 chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:337: // TODO(jeremya) we need to call RenderViewHost::ExitFullscreen() if we ...
5 years, 6 months ago (2015-06-11 01:26:02 UTC) #4
tapted
sg still lgtm
5 years, 6 months ago (2015-06-11 03:31:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176823002/20001
5 years, 6 months ago (2015-06-11 03:46:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 04:20:08 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 04:21:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6063e8bb90fec5e53b5b1187de367b9d3adb68b9
Cr-Commit-Position: refs/heads/master@{#333892}

Powered by Google App Engine
This is Rietveld 408576698