Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1176763006: Sky Style Guide. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
A sky/specs/style-guide.md View 1 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Matt Perry
https://codereview.chromium.org/1176763006/diff/1/sky/specs/style-guide.md File sky/specs/style-guide.md (right): https://codereview.chromium.org/1176763006/diff/1/sky/specs/style-guide.md#newcode1 sky/specs/style-guide.md:1: Sky Style Guide Should mention near the top that ...
5 years, 6 months ago (2015-06-10 18:36:49 UTC) #2
eseidel
I would move the "follow Dart style guide" bit to the top. I view this ...
5 years, 6 months ago (2015-06-10 19:23:12 UTC) #4
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-10 19:31:07 UTC) #6
Hixie
5 years, 6 months ago (2015-06-10 19:37:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4ba1ba79858135e237c2a8ed5bfbea3c4fabc11d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698