Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1176713003: Make the CSS interface members static (Closed)

Created:
4 years, 10 months ago by ramya.v
Modified:
4 years, 10 months ago
CC:
blink-reviews, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make the CSS interface members static BUG=496369 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196943

Patch Set 1 #

Patch Set 2 : Updating test expectations #

Total comments: 4

Patch Set 3 : Updating as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -41 lines) Patch
M LayoutTests/platform/android/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSS.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/DOMWindowCSS.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/DOMWindowCSS.cpp View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/frame/RemoteDOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/RemoteDOMWindow.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ramya.v
PTAL! Thanks
4 years, 10 months ago (2015-06-10 13:46:17 UTC) #2
Rick Byers
On 2015/06/10 13:46:17, ramya.v wrote: > PTAL! > > Thanks Tim's the right reviewer for ...
4 years, 10 months ago (2015-06-10 14:23:30 UTC) #4
Timothy Loh
Would be nice if we could make DOMWindowCSS static-only, but it looks like we can't ...
4 years, 10 months ago (2015-06-11 01:06:36 UTC) #5
ramya.v
Updated as per review comments. PTAL! Thanks https://codereview.chromium.org/1176713003/diff/20001/Source/core/css/DOMWindowCSS.h File Source/core/css/DOMWindowCSS.h (left): https://codereview.chromium.org/1176713003/diff/20001/Source/core/css/DOMWindowCSS.h#oldcode44 Source/core/css/DOMWindowCSS.h:44: static PassRefPtrWillBeRawPtr<DOMWindowCSS> ...
4 years, 10 months ago (2015-06-11 06:25:33 UTC) #6
Timothy Loh
lgtm
4 years, 10 months ago (2015-06-11 08:34:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176713003/40001
4 years, 10 months ago (2015-06-11 10:02:24 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196943
4 years, 10 months ago (2015-06-11 12:18:28 UTC) #10
philipj_slow
4 years, 10 months ago (2015-06-11 12:33:20 UTC) #12
Message was sent while issue was closed. 
\o/

Powered by Google App Engine
This is Rietveld 408576698