Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1176713002: Synchronously drop tile textures in android webview (Closed)

Created:
5 years, 6 months ago by boliu
Modified:
5 years, 6 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Synchronously drop tile textures in android webview Merely applying zero memory is not enough to synchronously drop all tile textures. Instead destroy and recreate TileManager instead. BUG=496057, 499004 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3d442d362ddec4594dc12983d88bdbe24f1c361c Cr-Commit-Position: refs/heads/master@{#334020}

Patch Set 1 #

Patch Set 2 : simplify #

Patch Set 3 : remove extra if #

Total comments: 2

Patch Set 4 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
boliu
ptal Note intending to merge this back to m44.
5 years, 6 months ago (2015-06-10 21:44:44 UTC) #2
boliu
+danakj
5 years, 6 months ago (2015-06-10 22:06:03 UTC) #4
vmpstr
Overall this looks fine to me, can you add a TODO(boliu) or TODO(vmpstr) to the ...
5 years, 6 months ago (2015-06-10 23:15:54 UTC) #5
boliu
https://codereview.chromium.org/1176713002/diff/40001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1176713002/diff/40001/cc/trees/layer_tree_host_impl.cc#newcode1337 cc/trees/layer_tree_host_impl.cc:1337: DestroyTileManager(); On 2015/06/10 23:15:54, vmpstr wrote: > Can you ...
5 years, 6 months ago (2015-06-10 23:20:56 UTC) #6
vmpstr
lgtm
5 years, 6 months ago (2015-06-11 17:35:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176713002/60001
5 years, 6 months ago (2015-06-11 18:59:48 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-11 20:01:39 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 20:03:39 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3d442d362ddec4594dc12983d88bdbe24f1c361c
Cr-Commit-Position: refs/heads/master@{#334020}

Powered by Google App Engine
This is Rietveld 408576698