Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 1176703002: Make guard_cid and nullable_cid half words. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc
index 9474ebda0e8fa7deb5e71e3dd3e8a5122e5a75b3..7cd7f332c7c663b45ff9f35ccebd81a5f19cb638 100644
--- a/runtime/vm/intermediate_language_x64.cc
+++ b/runtime/vm/intermediate_language_x64.cc
@@ -1480,13 +1480,13 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
if (value_cid == kDynamicCid) {
LoadValueCid(compiler, value_cid_reg, value_reg);
- __ cmpl(value_cid_reg, field_cid_operand);
+ __ cmpw(value_cid_reg, field_cid_operand);
__ j(EQUAL, &ok);
- __ cmpl(value_cid_reg, field_nullability_operand);
+ __ cmpw(value_cid_reg, field_nullability_operand);
} else if (value_cid == kNullCid) {
- __ cmpl(field_nullability_operand, Immediate(value_cid));
+ __ cmpw(field_nullability_operand, Immediate(value_cid));
} else {
- __ cmpl(field_cid_operand, Immediate(value_cid));
+ __ cmpw(field_cid_operand, Immediate(value_cid));
}
__ j(EQUAL, &ok);
@@ -1497,16 +1497,16 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
if (!field().needs_length_check()) {
// Uninitialized field can be handled inline. Check if the
// field is still unitialized.
- __ cmpl(field_cid_operand, Immediate(kIllegalCid));
+ __ cmpw(field_cid_operand, Immediate(kIllegalCid));
__ j(NOT_EQUAL, fail);
if (value_cid == kDynamicCid) {
- __ movl(field_cid_operand, value_cid_reg);
- __ movl(field_nullability_operand, value_cid_reg);
+ __ movw(field_cid_operand, value_cid_reg);
+ __ movw(field_nullability_operand, value_cid_reg);
} else {
ASSERT(field_reg != kNoRegister);
- __ movl(field_cid_operand, Immediate(value_cid));
- __ movl(field_nullability_operand, Immediate(value_cid));
+ __ movw(field_cid_operand, Immediate(value_cid));
+ __ movw(field_nullability_operand, Immediate(value_cid));
}
if (deopt == NULL) {
@@ -1519,7 +1519,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(!compiler->is_optimizing());
__ Bind(fail);
- __ cmpl(FieldAddress(field_reg, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(field_reg, Field::guarded_cid_offset()),
Immediate(kDynamicCid));
__ j(EQUAL, &ok);
@@ -1842,7 +1842,7 @@ void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ LoadObject(temp, Field::ZoneHandle(field().raw()), PP);
- __ cmpl(FieldAddress(temp, Field::is_nullable_offset()),
+ __ cmpw(FieldAddress(temp, Field::is_nullable_offset()),
Immediate(kNullCid));
__ j(EQUAL, &store_pointer);
@@ -1850,15 +1850,15 @@ void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ testq(temp2, Immediate(1 << Field::kUnboxingCandidateBit));
__ j(ZERO, &store_pointer);
- __ cmpl(FieldAddress(temp, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(temp, Field::guarded_cid_offset()),
Immediate(kDoubleCid));
__ j(EQUAL, &store_double);
- __ cmpl(FieldAddress(temp, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(temp, Field::guarded_cid_offset()),
Immediate(kFloat32x4Cid));
__ j(EQUAL, &store_float32x4);
- __ cmpl(FieldAddress(temp, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(temp, Field::guarded_cid_offset()),
Immediate(kFloat64x2Cid));
__ j(EQUAL, &store_float64x2);
@@ -2202,19 +2202,19 @@ void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ LoadObject(result, Field::ZoneHandle(field()->raw()), PP);
- __ cmpl(FieldAddress(result, Field::is_nullable_offset()),
+ __ cmpw(FieldAddress(result, Field::is_nullable_offset()),
Immediate(kNullCid));
__ j(EQUAL, &load_pointer);
- __ cmpl(FieldAddress(result, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(result, Field::guarded_cid_offset()),
Immediate(kDoubleCid));
__ j(EQUAL, &load_double);
- __ cmpl(FieldAddress(result, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(result, Field::guarded_cid_offset()),
Immediate(kFloat32x4Cid));
__ j(EQUAL, &load_float32x4);
- __ cmpl(FieldAddress(result, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(result, Field::guarded_cid_offset()),
Immediate(kFloat64x2Cid));
__ j(EQUAL, &load_float64x2);
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698