remoting/webapp/base/js/server_log_entry.js - Issue 1176693002: Add more host-side connection state logging for IT2Me.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/base/js/server_log_entry.js

Issue 1176693002: Add more host-side connection state logging for IT2Me. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Log connection-canceled if the user cancels installation. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/webapp/base/js/log_to_server.js ('k') | remoting/webapp/crd/js/buffered_signal_strategy.js » ('j') | remoting/webapp/crd/js/host_controller.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/base/js/server_log_entry.js

diff --git a/remoting/webapp/base/js/server_log_entry.js b/remoting/webapp/base/js/server_log_entry.js

index 0af065f498c0dd9883b9e8971717fd71db137e16..c38f9aeda75a5db60605f4d1ac6ffdf501850098 100644

--- a/remoting/webapp/base/js/server_log_entry.js

+++ b/remoting/webapp/base/js/server_log_entry.js

@@ -216,13 +216,14 @@ remoting.ServerLogEntry.prototype.toDebugLog = function(indentLevel) {

* @param {remoting.ClientSession.State} state

* @param {!remoting.Error} connectionError

* @param {string} mode The current app mode (It2Me, Me2Me, AppRemoting).

+ * @param {string} role 'client' if the app is acting as a Chromoting client

+ * or 'host' if it is acting as a host (IT2Me)

* @return {remoting.ServerLogEntry}

remoting.ServerLogEntry.makeClientSessionStateChange = function(state,

- connectionError, mode) {

+ connectionError, mode, role) {

var entry = new remoting.ServerLogEntry();

- entry.set_(remoting.ServerLogEntry.KEY_ROLE_,

- remoting.ServerLogEntry.VALUE_ROLE_CLIENT_);

+ entry.set_(remoting.ServerLogEntry.KEY_ROLE_, role);

entry.set_(remoting.ServerLogEntry.KEY_EVENT_NAME_,

remoting.ServerLogEntry.VALUE_EVENT_NAME_SESSION_STATE_);

entry.set_(remoting.ServerLogEntry.KEY_SESSION_STATE_,

@@ -439,4 +440,3 @@ remoting.ServerLogEntry.prototype.addModeField = function(mode) {

remoting.ServerLogEntry.prototype.addApplicationId = function() {

this.set_(remoting.ServerLogEntry.KEY_APP_ID_, chrome.runtime.id);

};