Add more host-side connection state logging for IT2Me.

Add more host-side connection state logging for IT2Me.

This CL adds INITIALIZING, CONNECTING, FAILED and CANCELED states to the host-side IT2Me
connection set-up. It has the following components:

* BufferedSignalStrategy: A new class to wrap an underlying SignalStrategy so that messages
  can be logged before the XMPP connection is established. Doing otherwise would slow down
  connections unnecessarily, but a consequence is that we aren't guaranteed that the new
  messages will actually be logged; still it's better than the previous situation.
* Support for host-side logging in LogToServer.
* Minimal refactoring to make the code that reads the local host version publicly callable.

Note that some of this code, in particular the BufferedSignalStrategy class should go away
if we implement logging using XHRs.

BUG=497876
Committed: https://crrev.com/9ea60d8ecacbccac0221c7f576ef19d6635de1cd
Cr-Commit-Position: refs/heads/master@{#333771}

[Jamie, 2015-06-10 00:38:29]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-06-10 00:38:30]

ptal

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_screen.js (right):

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_screen.js:43: it2meLogger.setSessionId();
This forces a fresh session id each time the user clicks Share, but it will not
be the same as the session id used by the C++ code. Fixing that will need plugin
changes and since we only need aggregate numbers for now, I prefer to do it in a
separate CL.

[kelvinp, 2015-06-10 18:00:45]

lgtm

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_controller.js (right):

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:24:
this.getLocalHostVersion().then(printVersion, function() {
Nit: Use .catch for error handling for readability.

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_screen.js (right):

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_screen.js:402: function() {
use .catch for readability
return remoting.hostController.getLocalHostVersion().then(
  function(/** string */ version) {
    it2meLogger.setHostVersion(version);
  }).catch(
     base.doNothing
  );

[Jamie, 2015-06-10 18:14:32]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-06-10 18:14:33]

The patchset sent to the CQ was uploaded after l-g-t-m from kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1176693002/#ps40001
(title: "Reviewer feedback.")

[Jamie, 2015-06-10 18:14:44]

FYI

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_controller.js (right):

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:24:
this.getLocalHostVersion().then(printVersion, function() {
On 2015/06/10 18:00:45, kelvinp wrote:
> Nit: Use .catch for error handling for readability.

Done.

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_screen.js (right):

https://codereview.chromium.org/1176693002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_screen.js:402: function() {
On 2015/06/10 18:00:45, kelvinp wrote:
> use .catch for readability
> return remoting.hostController.getLocalHostVersion().then(
>   function(/** string */ version) {
>     it2meLogger.setHostVersion(version);
>   }).catch(
>      base.doNothing
>   );

Done.

[commit-bot: I haz the power, 2015-06-10 18:15:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176693002/40001

[commit-bot: I haz the power, 2015-06-10 19:18:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 19:18:55]

Patchset 3 (id:??) landed as
https://crrev.com/9ea60d8ecacbccac0221c7f576ef19d6635de1cd
Cr-Commit-Position: refs/heads/master@{#333771}