Use callback instead of weak pointer in OutputSurfaceWithoutParent.

Use callback instead of weak pointer in OutputSurfaceWithoutParent.

Using a weak ptr for compositor_impl_ is unnecessary if we are not
checking for null. Using a callback with an unretained ptr is better.

Committed: https://crrev.com/b4b56fbc7d91881982884dee01ae8de7459463fc
Cr-Commit-Position: refs/heads/master@{#333622}

[sunnyps, 2015-06-09 20:28:42]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 20:29:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176643002/1

[sunnyps, 2015-06-09 20:31:40]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[sunnyps, 2015-06-09 20:31:49]

The CQ bit was unchecked by sunnyps@chromium.org

[sunnyps, 2015-06-09 22:01:46]

sunnyps@chromium.org changed reviewers:
+ sievers@chromium.org

[sunnyps, 2015-06-09 22:01:46]

PTAL

[no sievers, 2015-06-09 22:48:30]

lgtm

https://codereview.chromium.org/1176643002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/1176643002/diff/40001/content/browser/rendere...
content/browser/renderer_host/compositor_impl_android.cc:648:
weak_factory_.GetWeakPtr())));
The OutputSurface should not be able to outlive the CompositorImpl, since the
CompositorImpl owns the LayerTreeHost.

But maybe leave it for now, since we are not able to get rid of the
weak_factory_ anyways (it's used in one other place).

[sunnyps, 2015-06-09 23:38:47]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-06-09 23:38:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1176643002/#ps60001
(title: " ")

[sunnyps, 2015-06-09 23:39:35]

Changed the weak ptr to base::Unretained and updated the commit message.

https://codereview.chromium.org/1176643002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/1176643002/diff/40001/content/browser/rendere...
content/browser/renderer_host/compositor_impl_android.cc:648:
weak_factory_.GetWeakPtr())));
On 2015/06/09 22:48:30, sievers wrote:
> The OutputSurface should not be able to outlive the CompositorImpl, since the
> CompositorImpl owns the LayerTreeHost.
> 
> But maybe leave it for now, since we are not able to get rid of the
> weak_factory_ anyways (it's used in one other place).

Done.

[commit-bot: I haz the power, 2015-06-09 23:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176643002/60001

[commit-bot: I haz the power, 2015-06-10 00:45:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-10 00:46:43]

Patchset 4 (id:??) landed as
https://crrev.com/b4b56fbc7d91881982884dee01ae8de7459463fc
Cr-Commit-Position: refs/heads/master@{#333622}