Issue 117663003: Fix icu link warning on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117663003: Fix icu link warning on Windows (Closed)

Created:
7 years ago by Will Harris

Modified:
6 years, 11 months ago

Reviewers:
jungshik at Google

Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master

Visibility:
Public.

More Reviews

Description

Fix icu link warning on Windows BUG=325982 TEST=run builds with and without component=shared_library and verify no linker warning are emitted. Run net_unittests --gtest_filter=NetUtil*.* R=jshin@chromium.org Committed: 243425

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
M	README.chromium	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	patches/declspec.patch	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	source/common/unicode/utypes.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

On 2013/12/17 22:25:22, Will Harris wrote: LGTM, but can you hold this CL until a ...

7 years ago (2013-12-19 01:30:01 UTC) #2

Will Harris

6 years, 11 months ago (2014-01-07 23:14:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r243425 (presubmit successful).

Expand Messages | Collapse Messages