Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: sky/sdk/lib/framework/rendering/box.dart

Issue 1176623002: Add asserts to prevent people from setting box.parentData.position or box.size except during layout. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/framework/rendering/object.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/box.dart
diff --git a/sky/sdk/lib/framework/rendering/box.dart b/sky/sdk/lib/framework/rendering/box.dart
index b4d970026d1e2a367d7aab62139b0550a09d8143..520625626635d6ad86ce6195cdedd370a5a71dee 100644
--- a/sky/sdk/lib/framework/rendering/box.dart
+++ b/sky/sdk/lib/framework/rendering/box.dart
@@ -159,7 +159,12 @@ class BoxConstraints {
}
class BoxParentData extends ParentData {
- Point position = Point.origin;
+ Point _position = Point.origin;
+ Point get position => _position;
+ void set position(Point value) {
+ assert(RenderObject.debugDoingLayout);
+ _position = value;
+ }
String toString() => 'position=$position';
}
@@ -218,7 +223,12 @@ abstract class RenderBox extends RenderObject {
}
void hitTestChildren(HitTestResult result, { Point position }) { }
- Size size = Size.zero;
+ Size _size = Size.zero;
+ Size get size => _size;
+ void set size(Size value) {
+ assert(RenderObject.debugDoingLayout);
+ _size = value;
+ }
String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}size: ${size}\n';
}
« no previous file with comments | « no previous file | sky/sdk/lib/framework/rendering/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698