Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1176613002: Catch IOError when reading chartjson results in test_runner.py (Closed)

Created:
5 years, 6 months ago by shatch
Modified:
5 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch IOError when reading chartjson results in test_runner.py Right now, if the results aren't there, the entire sharded perf tests step fails. This doesn't fix the underlying issue, but at least allows the rest of the tests to run and makes it clearer which step failed. With Patch: http://simonhatch0.mon.corp.google.com:8013/builders/Android%20Nexus7v2%20Perf/builds/593 Without: http://simonhatch0.mon.corp.google.com:8013/builders/Android%20Nexus7v2%20Perf/builds/591 BUG=498412 Committed: https://crrev.com/eca5b79197f9f2e8c15ea8e55477d424649b1cc9 Cr-Commit-Position: refs/heads/master@{#333593}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change to logging.exception. #

Total comments: 2

Patch Set 3 : Remove e. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/android/pylib/perf/test_runner.py View 1 2 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
shatch
5 years, 6 months ago (2015-06-09 19:52:46 UTC) #2
jbudorick
This isn't going to solve the underlying problem, though it may allow ShardedPerfTests to continue. ...
5 years, 6 months ago (2015-06-09 19:54:17 UTC) #3
jbudorick
https://codereview.chromium.org/1176613002/diff/20001/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/1176613002/diff/20001/build/android/pylib/perf/test_runner.py#newcode240 build/android/pylib/perf/test_runner.py:240: logging.exception('Exception when reading chartjson: %s', e) logging.exception automatically logs ...
5 years, 6 months ago (2015-06-09 20:00:59 UTC) #4
shatch
https://codereview.chromium.org/1176613002/diff/20001/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/1176613002/diff/20001/build/android/pylib/perf/test_runner.py#newcode240 build/android/pylib/perf/test_runner.py:240: logging.exception('Exception when reading chartjson: %s', e) On 2015/06/09 20:00:59, ...
5 years, 6 months ago (2015-06-09 20:33:47 UTC) #5
jbudorick
lgtm
5 years, 6 months ago (2015-06-09 20:42:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176613002/40001
5 years, 6 months ago (2015-06-09 20:52:57 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-09 22:20:24 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:21:49 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eca5b79197f9f2e8c15ea8e55477d424649b1cc9
Cr-Commit-Position: refs/heads/master@{#333593}

Powered by Google App Engine
This is Rietveld 408576698