Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1176503002: Rename isNormalFlowOnly to something meaningful (Closed)

Created:
4 years, 10 months ago by Julien - ping for review
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Rename isNormalFlowOnly to something meaningful The boolean was confusing and needed a lot of explanation for new people. The idea behind it is really that we "treat some elements as stacking context" for the purpose of painting and hit testing, even if they are not (e.g. positioned elements). This is a requirement by CSS 2.1, appendix E. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196798

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nittified! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.cpp View 5 chunks +8 lines, -15 lines 0 comments Download
M Source/core/style/ComputedStyle.h View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Julien - ping for review
Name bikeshedding, take 1!
4 years, 10 months ago (2015-06-09 17:35:03 UTC) #2
leviw_travelin_and_unemployed
I actually quite like the periwinkle of your paint, sir! LGTM. This is much clearer, ...
4 years, 10 months ago (2015-06-09 18:29:01 UTC) #3
Julien - ping for review
Thanks for your thistling review, sir Levi! https://codereview.chromium.org/1176503002/diff/1/Source/core/style/ComputedStyle.h File Source/core/style/ComputedStyle.h (right): https://codereview.chromium.org/1176503002/diff/1/Source/core/style/ComputedStyle.h#newcode1219 Source/core/style/ComputedStyle.h:1219: // FIXME: ...
4 years, 10 months ago (2015-06-09 19:39:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176503002/20001
4 years, 10 months ago (2015-06-09 19:40:22 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 20:43:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196798

Powered by Google App Engine
This is Rietveld 408576698