Optimize trivial regexp disjunctions

Optimize trivial regexp disjunctions

R=yangguo@chromium.org
BUG=chromium:482998
LOG=n

Committed: https://crrev.com/5f1f7c15b3207f6c51d187692690aeb09d3e36b5
Cr-Commit-Position: refs/heads/master@{#28871}

[Erik Corry Chromium.org, 2015-06-09 10:14:23]

The CQ bit was checked by erikcorry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 10:14:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/40001

[commit-bot: I haz the power, 2015-06-09 10:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 10:19:08]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Yang, 2015-06-09 10:59:35]

https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc#newcode4920
src/jsregexp.cc:4920: new (zone) RegExpAtom(suffix_list->ToConstVector());
We could just use old_atom->data()->SubVector(1, len) instead of creating it
from a list.

But I wonder whether we could just reuse the old RegExpAtom instances?

https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc#newcode5000
src/jsregexp.cc:5000: return alternatives->at(0)->ToNode(compiler, on_success);
I guess for something like aaaaaaaaaaaaaaab|aaaaaaaaaaaaaaac|aaaaaaaaaaaaaaad
this would lead to running rationalize 15 times, each time producing one
character of prefix?

[Yang, 2015-06-09 11:00:26]

On 2015/06/09 10:59:35, Yang wrote:
> https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc
> File src/jsregexp.cc (right):
> 
> https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc#newcode4920
> src/jsregexp.cc:4920: new (zone) RegExpAtom(suffix_list->ToConstVector());
> We could just use old_atom->data()->SubVector(1, len) instead of creating it
> from a list.
> 
> But I wonder whether we could just reuse the old RegExpAtom instances?
> 
> https://codereview.chromium.org/1176453002/diff/1/src/jsregexp.cc#newcode5000
> src/jsregexp.cc:5000: return alternatives->at(0)->ToNode(compiler,
on_success);
> I guess for something like aaaaaaaaaaaaaaab|aaaaaaaaaaaaaaac|aaaaaaaaaaaaaaad
> this would lead to running rationalize 15 times, each time producing one
> character of prefix?

Otherwise lgtm.

[Erik Corry Chromium.org, 2015-06-09 11:15:18]

The CQ bit was checked by erikcorry@chromium.org to run a CQ dry run

[Erik Corry Chromium.org, 2015-06-09 11:15:19]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1176453002/#ps80001
(title: "Fix int truncation error")

[commit-bot: I haz the power, 2015-06-09 11:15:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/80001

[commit-bot: I haz the power, 2015-06-09 11:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 11:28:39]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Erik Corry Chromium.org, 2015-06-09 12:01:43]

The CQ bit was checked by erikcorry@chromium.org to run a CQ dry run

[Erik Corry Chromium.org, 2015-06-09 12:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1176453002/#ps100001
(title: "Fix code size test")

[commit-bot: I haz the power, 2015-06-09 12:01:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/100001

[commit-bot: I haz the power, 2015-06-09 12:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 12:27:55]

Dry run: This issue passed the CQ dry run.

[Erik Corry Chromium.org, 2015-06-09 13:03:04]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-09 13:03:05]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1176453002/#ps120001
(title: "Collect large common prefixes in one go and use SubVector")

[commit-bot: I haz the power, 2015-06-09 13:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/120001

[Erik Corry Chromium.org, 2015-06-09 13:04:46]

The CQ bit was unchecked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-09 13:05:28]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-09 13:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1176453002/#ps140001
(title: "Typo")

[commit-bot: I haz the power, 2015-06-09 13:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/140001

[Erik Corry Chromium.org, 2015-06-09 13:29:43]

The CQ bit was unchecked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-09 13:40:35]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-09 13:40:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1176453002/#ps160001
(title: "Add test")

[commit-bot: I haz the power, 2015-06-09 13:40:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/160001

[Erik Corry Chromium.org, 2015-06-09 14:18:51]

The CQ bit was checked by erikcorry@chromium.org

[Erik Corry Chromium.org, 2015-06-09 14:18:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1176453002/#ps180001
(title: "Make test faster")

[commit-bot: I haz the power, 2015-06-09 14:19:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176453002/180001

[commit-bot: I haz the power, 2015-06-09 15:58:00]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-06-09 15:58:12]

Patchset 10 (id:??) landed as
https://crrev.com/5f1f7c15b3207f6c51d187692690aeb09d3e36b5
Cr-Commit-Position: refs/heads/master@{#28871}

[Erik Corry Chromium.org, 2015-06-09 17:14:30]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1174603002/ by erikcorry@chromium.org.

The reason for reverting is: ASAN failure.