Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: Source/core/input/EventHandler.cpp

Issue 1176423008: Forward mouse down node information to WebWidgetClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/ChromeClient.h » ('j') | Source/core/page/ChromeClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/input/EventHandler.cpp
diff --git a/Source/core/input/EventHandler.cpp b/Source/core/input/EventHandler.cpp
index 19698b6bf5a0b587896378adc6a5058273c8515d..999396f407ddf3f3fc609cad0f0d18096c7d8d9f 100644
--- a/Source/core/input/EventHandler.cpp
+++ b/Source/core/input/EventHandler.cpp
@@ -998,6 +998,12 @@ bool EventHandler::handleMousePressEvent(const PlatformMouseEvent& mouseEvent)
swallowEvent = handleMousePressEvent(mev);
}
+ if (mev.hitTestResult().innerNode() && mouseEvent.button() == LeftButton) {
please use gerrit instead 2015/06/17 20:07:07 && mouseEvent.type() == PlatformMouseEvent::MouseP
Yufeng Shen (Slow to review) 2015/06/17 20:12:57 This is inside handleMousePressEvent(), so it is g
please use gerrit instead 2015/06/17 20:58:05 In that case, please "ASSERT(mouseEvent.type() ==
Yufeng Shen (Slow to review) 2015/06/17 22:25:50 Done.
+ HitTestResult result = mev.hitTestResult();
+ result.setToShadowHostIfInUserAgentShadowRoot();
+ m_frame->chromeClient().onClickInput(result.innerNode());
+ }
+
return swallowEvent;
}
@@ -2074,6 +2080,13 @@ bool EventHandler::handleGestureTap(const GestureEventWithHitTestResults& target
IntPoint tappedPositionInViewport = m_frame->page()->frameHost().pinchViewport().rootFrameToViewport(tappedPosition);
m_frame->chromeClient().showUnhandledTapUIIfNeeded(tappedPositionInViewport, tappedNode.get(), domTreeChanged || styleChanged);
}
+
+ if (currentHitTest.innerNode()) {
please use gerrit instead 2015/06/17 20:07:07 && gestureEvent.type() == PlatformEvent::GestureTa
Yufeng Shen (Slow to review) 2015/06/17 20:12:56 ditto, this is inside handleGestureTap().
please use gerrit instead 2015/06/17 20:58:05 Please "ASSERT(gestureEvent.type() == PlatformEven
Yufeng Shen (Slow to review) 2015/06/17 22:25:50 Done.
+ HitTestResult result = currentHitTest;
+ result.setToShadowHostIfInUserAgentShadowRoot();
+ m_frame->chromeClient().onClickInput(result.innerNode());
+ }
+
return swallowed;
}
« no previous file with comments | « no previous file | Source/core/page/ChromeClient.h » ('j') | Source/core/page/ChromeClient.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698