Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1176423007: Reenable some cctest tests that no longer fail. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reenable some cctest tests that no longer fail. R=jochen@chromium.org,jarin@chromium.org TEST=cctest Committed: https://crrev.com/9e7732c5175e31409e57ff38474b76afab07c6c4 Cr-Commit-Position: refs/heads/master@{#29092}

Patch Set 1 #

Patch Set 2 : Remove DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/heap/mark-compact.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-17 09:39:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-17 09:40:33 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-17 09:44:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176423007/20001
5 years, 6 months ago (2015-06-17 14:40:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 14:56:00 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 14:56:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e7732c5175e31409e57ff38474b76afab07c6c4
Cr-Commit-Position: refs/heads/master@{#29092}

Powered by Google App Engine
This is Rietveld 408576698