Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1176403005: Revert of [turbofan] Disable select matching due to bug manifesting on arm. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Disable select matching due to bug manifesting on arm. (patchset #1 id:1 of https://codereview.chromium.org/1077613002/) Reason for revert: [Sheriff] Checking if this still fails and if yes persists info about failures. Original issue's description: > [turbofan] Disable select matching due to bug manifesting on arm. > > R=machenbach@chromium.org > BUG= > > Committed: https://crrev.com/6e5d805718195c4b5ac64cd540379cecf10b8f5c > Cr-Commit-Position: refs/heads/master@{#27702} TBR=bmeurer@chromium.org Committed: https://crrev.com/7c36a7d91d8706b29df07013085fbe3c8e93b0ed Cr-Commit-Position: refs/heads/master@{#29103}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/pipeline.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
Created Revert of [turbofan] Disable select matching due to bug manifesting on arm.
5 years, 6 months ago (2015-06-18 06:55:15 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-18 07:00:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176403005/40001
5 years, 6 months ago (2015-06-18 07:29:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-18 07:57:18 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7c36a7d91d8706b29df07013085fbe3c8e93b0ed Cr-Commit-Position: refs/heads/master@{#29103}
5 years, 6 months ago (2015-06-18 07:57:42 UTC) #8
Michael Achenbach
5 years, 6 months ago (2015-06-18 10:42:22 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1195563003/ by machenbach@chromium.org.

The reason for reverting is: This causes timeouts in Massive on chromebooks..

Powered by Google App Engine
This is Rietveld 408576698