Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1176383002: Revert of Introduce the devices Mojo app (Closed)

Created:
5 years, 6 months ago by kjellander_chromium
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce the devices Mojo app (patchset #5 id:160001 of https://codereview.chromium.org/1165223004/) Reason for revert: This broke the Win 8 GN (dbg) and Win x64 GN (dbg) bots: https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/7453 https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/3219 Original issue's description: > Introduce the devices Mojo app > > It's a small Mojo app that currently only hosts USB device > services. This CL adds the app along with an apptest suite > (run manually with mojo_runner mojo:devices_apptests). > > The app is hooked up to Chrome to run in the browser process, > though there are currently no production code paths which > cause the app to launch. > > BUG=498557 > > Committed: https://crrev.com/ed800dc138edfa261aa766281b96f736ff9824f6 > Cr-Commit-Position: refs/heads/master@{#333899} TBR=reillyg@chromium.org,sky@chromium.org,rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498557 Committed: https://crrev.com/0e5fc2b42b268fab5d9ea3276235db58b7d61d1c Cr-Commit-Position: refs/heads/master@{#333942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -576 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M device/core/device_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
M device/core/device_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
D device/devices_app/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
D device/devices_app/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/devices_app/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D device/devices_app/devices_app.h View 1 chunk +0 lines, -81 lines 0 comments Download
D device/devices_app/devices_app.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D device/devices_app/devices_app.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
D device/devices_app/devices_apptest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D device/devices_app/main.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M device/usb/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/device_manager_impl.h View 3 chunks +11 lines, -19 lines 0 comments Download
M device/usb/device_manager_impl.cc View 3 chunks +49 lines, -95 lines 0 comments Download
M device/usb/device_manager_impl_unittest.cc View 6 chunks +36 lines, -13 lines 0 comments Download
M device/usb/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A device/usb/public/cpp/device_manager_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
M device/usb/usb_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
Created Revert of Introduce the devices Mojo app
5 years, 6 months ago (2015-06-11 13:40:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176383002/1
5 years, 6 months ago (2015-06-11 13:40:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 13:41:37 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 13:42:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e5fc2b42b268fab5d9ea3276235db58b7d61d1c
Cr-Commit-Position: refs/heads/master@{#333942}

Powered by Google App Engine
This is Rietveld 408576698