Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1176373004: Wire up Android back button in SkyShell (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson_old, eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Wire up Android back button in SkyShell The back button now triggers an event of type |back|. R=eseidel@chromium.org, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5b4a6937f0c0d4b1ca950748b91b283693f2ed1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M sky/engine/public/platform/WebInputEvent.h View 2 chunks +6 lines, -0 lines 0 comments Download
M sky/engine/public/sky/sky_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/raw/hello_world.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/services/viewport/input_event.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/SkyActivity.java View 1 chunk +11 lines, -0 lines 0 comments Download
M sky/shell/ui/input_event_converter.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-11 21:22:09 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-11 21:23:44 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-11 21:33:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b4a6937f0c0d4b1ca950748b91b283693f2ed1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698