Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: Source/devtools/front_end/ui/SidebarPane.js

Issue 1176343002: DevTools: make toolbar button click targets square (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/ui/SearchableView.js ('k') | Source/devtools/front_end/ui/Toolbar.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 * @param {!WebInspector.SidebarPane} pane 184 * @param {!WebInspector.SidebarPane} pane
185 * @param {boolean} visible 185 * @param {boolean} visible
186 */ 186 */
187 _setPaneVisible: function(pane, visible) 187 _setPaneVisible: function(pane, visible)
188 { 188 {
189 var title = this._titleByPane.get(pane); 189 var title = this._titleByPane.get(pane);
190 if (!title) 190 if (!title)
191 return; 191 return;
192 192
193 title.element.classList.toggle("hidden", !visible); 193 title.element.classList.toggle("hidden", !visible);
194 pane.element.classList.toggle("hidden", !visible); 194 pane.element.classList.toggle("sidebar-pane-hidden", !visible);
195 }, 195 },
196 196
197 __proto__: WebInspector.Widget.prototype 197 __proto__: WebInspector.Widget.prototype
198 } 198 }
199 199
200 /** 200 /**
201 * @constructor 201 * @constructor
202 * @extends {WebInspector.TabbedPane} 202 * @extends {WebInspector.TabbedPane}
203 */ 203 */
204 WebInspector.SidebarTabbedPane = function() 204 WebInspector.SidebarTabbedPane = function()
(...skipping 27 matching lines...) Expand all
232 if (!this.hasTab(title)) 232 if (!this.hasTab(title))
233 this.appendTab(title, title, pane); 233 this.appendTab(title, title, pane);
234 } else { 234 } else {
235 if (this.hasTab(title)) 235 if (this.hasTab(title))
236 this.closeTab(title); 236 this.closeTab(title);
237 } 237 }
238 }, 238 },
239 239
240 __proto__: WebInspector.TabbedPane.prototype 240 __proto__: WebInspector.TabbedPane.prototype
241 } 241 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ui/SearchableView.js ('k') | Source/devtools/front_end/ui/Toolbar.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698