Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1176343002: DevTools: make toolbar button click targets square (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 this._panelToolbar = new WebInspector.Toolbar(this.element); 304 this._panelToolbar = new WebInspector.Toolbar(this.element);
305 305
306 this.toggleTimelineButton = new WebInspector.ToolbarButton("Record timel ine", "record-toolbar-item"); 306 this.toggleTimelineButton = new WebInspector.ToolbarButton("Record timel ine", "record-toolbar-item");
307 this.toggleTimelineButton.addEventListener("click", this._toggleTimeline ButtonClicked, this); 307 this.toggleTimelineButton.addEventListener("click", this._toggleTimeline ButtonClicked, this);
308 this._panelToolbar.appendToolbarItem(this.toggleTimelineButton); 308 this._panelToolbar.appendToolbarItem(this.toggleTimelineButton);
309 this._updateToggleTimelineButton(false); 309 this._updateToggleTimelineButton(false);
310 310
311 var clearButton = new WebInspector.ToolbarButton(WebInspector.UIString(" Clear recording"), "clear-toolbar-item"); 311 var clearButton = new WebInspector.ToolbarButton(WebInspector.UIString(" Clear recording"), "clear-toolbar-item");
312 clearButton.addEventListener("click", this._onClearButtonClick, this); 312 clearButton.addEventListener("click", this._onClearButtonClick, this);
313 this._panelToolbar.appendToolbarItem(clearButton); 313 this._panelToolbar.appendToolbarItem(clearButton);
314 this._panelToolbar.appendSeparator();
314 315
315 this._filterBar = this._createFilterBar(); 316 this._filterBar = this._createFilterBar();
316 this._panelToolbar.appendToolbarItem(this._filterBar.filterButton()); 317 this._panelToolbar.appendToolbarItem(this._filterBar.filterButton());
317 318
318 var garbageCollectButton = new WebInspector.ToolbarButton(WebInspector.U IString("Collect garbage"), "garbage-collect-toolbar-item"); 319 var garbageCollectButton = new WebInspector.ToolbarButton(WebInspector.U IString("Collect garbage"), "garbage-collect-toolbar-item");
319 garbageCollectButton.addEventListener("click", this._garbageCollectButto nClicked, this); 320 garbageCollectButton.addEventListener("click", this._garbageCollectButto nClicked, this);
320 this._panelToolbar.appendToolbarItem(garbageCollectButton); 321 this._panelToolbar.appendToolbarItem(garbageCollectButton);
322 this._panelToolbar.appendSeparator();
321 323
322 var viewModeLabel = new WebInspector.ToolbarText(WebInspector.UIString(" View:"), "toolbar-group-label"); 324 var viewModeLabel = new WebInspector.ToolbarText(WebInspector.UIString(" View:"), "toolbar-group-label");
323 this._panelToolbar.appendToolbarItem(viewModeLabel); 325 this._panelToolbar.appendToolbarItem(viewModeLabel);
324 326
325 var framesToggleButton = new WebInspector.ToolbarButton(WebInspector.UIS tring("Frames view. (Activity split into frames)"), "histogram-toolbar-item"); 327 var framesToggleButton = new WebInspector.ToolbarButton(WebInspector.UIS tring("Frames view. (Activity split into frames)"), "histogram-toolbar-item");
326 framesToggleButton.setToggled(this._overviewModeSetting.get() === WebIns pector.TimelinePanel.OverviewMode.Frames); 328 framesToggleButton.setToggled(this._overviewModeSetting.get() === WebIns pector.TimelinePanel.OverviewMode.Frames);
327 framesToggleButton.addEventListener("click", this._overviewModeChanged.b ind(this, framesToggleButton)); 329 framesToggleButton.addEventListener("click", this._overviewModeChanged.b ind(this, framesToggleButton));
328 this._panelToolbar.appendToolbarItem(framesToggleButton); 330 this._panelToolbar.appendToolbarItem(framesToggleButton);
329 331
330 this._flameChartToggleButton = new WebInspector.ToolbarSettingToggle(thi s._flameChartEnabledSetting, "flame-chart-toolbar-item", WebInspector.UIString(" Flame chart view. (Use WASD or time selection to navigate)")); 332 this._flameChartToggleButton = new WebInspector.ToolbarSettingToggle(thi s._flameChartEnabledSetting, "flame-chart-toolbar-item", WebInspector.UIString(" Flame chart view. (Use WASD or time selection to navigate)"));
331 this._panelToolbar.appendToolbarItem(this._flameChartToggleButton); 333 this._panelToolbar.appendToolbarItem(this._flameChartToggleButton);
334 this._panelToolbar.appendSeparator();
332 335
333 var captureSettingsLabel = new WebInspector.ToolbarText(WebInspector.UIS tring("Capture:"), "toolbar-group-label"); 336 var captureSettingsLabel = new WebInspector.ToolbarText(WebInspector.UIS tring("Capture:"), "toolbar-group-label");
334 this._panelToolbar.appendToolbarItem(captureSettingsLabel); 337 this._panelToolbar.appendToolbarItem(captureSettingsLabel);
335 338
336 this._captureNetworkSetting = WebInspector.settings.createSetting("timel ineCaptureNetwork", false); 339 this._captureNetworkSetting = WebInspector.settings.createSetting("timel ineCaptureNetwork", false);
337 this._captureNetworkSetting.addChangeListener(this._onNetworkChanged, th is); 340 this._captureNetworkSetting.addChangeListener(this._onNetworkChanged, th is);
338 if (Runtime.experiments.isEnabled("networkRequestsOnTimeline")) { 341 if (Runtime.experiments.isEnabled("networkRequestsOnTimeline")) {
339 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Network"), 342 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Network"),
340 this._ captureNetworkSetting, 343 this._ captureNetworkSetting,
341 WebIns pector.UIString("Capture network requests information"))); 344 WebIns pector.UIString("Capture network requests information")));
(...skipping 1496 matching lines...) Expand 10 before | Expand all | Expand 10 after
1838 /** 1841 /**
1839 * @override 1842 * @override
1840 */ 1843 */
1841 reset: function() 1844 reset: function()
1842 { 1845 {
1843 this._filmStripView.reset(); 1846 this._filmStripView.reset();
1844 }, 1847 },
1845 1848
1846 __proto__: WebInspector.TimelineOverviewBase.prototype 1849 __proto__: WebInspector.TimelineOverviewBase.prototype
1847 } 1850 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sources/uiList.css ('k') | Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698