Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 1176343002: DevTools: make toolbar button click targets square (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 WebInspector.NetworkPanel.prototype = { 113 WebInspector.NetworkPanel.prototype = {
114 _createToolbarButtons: function() 114 _createToolbarButtons: function()
115 { 115 {
116 this._recordButton = new WebInspector.ToolbarButton("", "record-toolbar- item"); 116 this._recordButton = new WebInspector.ToolbarButton("", "record-toolbar- item");
117 this._recordButton.addEventListener("click", this._onRecordButtonClicked , this); 117 this._recordButton.addEventListener("click", this._onRecordButtonClicked , this);
118 this._panelToolbar.appendToolbarItem(this._recordButton); 118 this._panelToolbar.appendToolbarItem(this._recordButton);
119 119
120 this._clearButton = new WebInspector.ToolbarButton(WebInspector.UIString ("Clear"), "clear-toolbar-item"); 120 this._clearButton = new WebInspector.ToolbarButton(WebInspector.UIString ("Clear"), "clear-toolbar-item");
121 this._clearButton.addEventListener("click", this._onClearButtonClicked, this); 121 this._clearButton.addEventListener("click", this._onClearButtonClicked, this);
122 this._panelToolbar.appendToolbarItem(this._clearButton); 122 this._panelToolbar.appendToolbarItem(this._clearButton);
123 this._panelToolbar.appendSeparator();
123 124
124 if (Runtime.experiments.isEnabled("filmStripInNetworkAndTimeline")) { 125 if (Runtime.experiments.isEnabled("filmStripInNetworkAndTimeline")) {
125 var recordFilmStripButton = new WebInspector.ToolbarSettingToggle(th is._networkRecordFilmStripSetting, "camera-toolbar-item", WebInspector.UIString( "Capture screenshots")); 126 var recordFilmStripButton = new WebInspector.ToolbarSettingToggle(th is._networkRecordFilmStripSetting, "camera-toolbar-item", WebInspector.UIString( "Capture screenshots"));
126 this._panelToolbar.appendToolbarItem(recordFilmStripButton); 127 this._panelToolbar.appendToolbarItem(recordFilmStripButton);
127 } 128 }
128 129
129 this._panelToolbar.appendToolbarItem(this._filterBar.filterButton()); 130 this._panelToolbar.appendToolbarItem(this._filterBar.filterButton());
131 this._panelToolbar.appendSeparator();
130 132
131 var viewModeLabel = new WebInspector.ToolbarText(WebInspector.UIString(" View:"), "toolbar-group-label"); 133 var viewModeLabel = new WebInspector.ToolbarText(WebInspector.UIString(" View:"), "toolbar-group-label");
132 this._panelToolbar.appendToolbarItem(viewModeLabel); 134 this._panelToolbar.appendToolbarItem(viewModeLabel);
133 135
134 var largerRequestsButton = new WebInspector.ToolbarSettingToggle(this._n etworkLogLargeRowsSetting, "large-list-toolbar-item", WebInspector.UIString("Use large request rows"), WebInspector.UIString("Use small request rows")); 136 var largerRequestsButton = new WebInspector.ToolbarSettingToggle(this._n etworkLogLargeRowsSetting, "large-list-toolbar-item", WebInspector.UIString("Use large request rows"), WebInspector.UIString("Use small request rows"));
135 this._panelToolbar.appendToolbarItem(largerRequestsButton); 137 this._panelToolbar.appendToolbarItem(largerRequestsButton);
136 138
137 var showOverviewButton = new WebInspector.ToolbarSettingToggle(this._net workLogShowOverviewSetting, "waterfall-toolbar-item", WebInspector.UIString("Sho w overview"), WebInspector.UIString("Hide overview")); 139 var showOverviewButton = new WebInspector.ToolbarSettingToggle(this._net workLogShowOverviewSetting, "waterfall-toolbar-item", WebInspector.UIString("Sho w overview"), WebInspector.UIString("Hide overview"));
138 this._panelToolbar.appendToolbarItem(showOverviewButton); 140 this._panelToolbar.appendToolbarItem(showOverviewButton);
139 141 this._panelToolbar.appendSeparator();
140 var optionsLabel = new WebInspector.ToolbarText(WebInspector.UIString("O ptions:"), "toolbar-group-label");
141 this._panelToolbar.appendToolbarItem(optionsLabel);
142 142
143 this._preserveLogCheckbox = new WebInspector.ToolbarCheckbox(WebInspecto r.UIString("Preserve log"), WebInspector.UIString("Do not clear log on page relo ad / navigation")); 143 this._preserveLogCheckbox = new WebInspector.ToolbarCheckbox(WebInspecto r.UIString("Preserve log"), WebInspector.UIString("Do not clear log on page relo ad / navigation"));
144 this._preserveLogCheckbox.inputElement.addEventListener("change", this._ onPreserveLogCheckboxChanged.bind(this), false); 144 this._preserveLogCheckbox.inputElement.addEventListener("change", this._ onPreserveLogCheckboxChanged.bind(this), false);
145 this._panelToolbar.appendToolbarItem(this._preserveLogCheckbox); 145 this._panelToolbar.appendToolbarItem(this._preserveLogCheckbox);
146 146
147 this._disableCacheCheckbox = new WebInspector.ToolbarCheckbox(WebInspect or.UIString("Disable cache"), WebInspector.UIString("Disable cache (while DevToo ls is open)"), WebInspector.moduleSetting("cacheDisabled")); 147 this._disableCacheCheckbox = new WebInspector.ToolbarCheckbox(WebInspect or.UIString("Disable cache"), WebInspector.UIString("Disable cache (while DevToo ls is open)"), WebInspector.moduleSetting("cacheDisabled"));
148 this._panelToolbar.appendToolbarItem(this._disableCacheCheckbox); 148 this._panelToolbar.appendToolbarItem(this._disableCacheCheckbox);
149 149
150 this._panelToolbar.appendToolbarItem(new WebInspector.ToolbarItem(this._ progressBarContainer)); 150 this._panelToolbar.appendToolbarItem(new WebInspector.ToolbarItem(this._ progressBarContainer));
151 }, 151 },
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 { 698 {
699 if (!this._target) 699 if (!this._target)
700 return; 700 return;
701 701
702 this._target.tracingManager.stop(); 702 this._target.tracingManager.stop();
703 this._target = null; 703 this._target = null;
704 this._callback = callback; 704 this._callback = callback;
705 this._filmStripView.setFetching(); 705 this._filmStripView.setFetching();
706 } 706 }
707 } 707 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/main/module.json ('k') | Source/devtools/front_end/network/networkPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698