Implementing native chromium GeolocationPermissionContext

android_webview/native/aw_geolocation_permission_context.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "android_webview/native/aw_geolocation_permission_context.h"
+
+#include "android_webview/native/aw_contents.h"
+#include "base/bind.h"
+#include "base/callback.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "googleurl/src/gurl.h"
+
+namespace android_webview {
+
+AwGeolocationPermissionContext::~AwGeolocationPermissionContext() {
+}
+
+void
+AwGeolocationPermissionContext::RequestGeolocationPermissionOnUIThread(
+    int render_process_id,
+    int render_view_id,
+    int bridge_id,
+    const GURL& requesting_frame,
+    base::Callback<void(bool)> callback) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  const content::RenderViewHost* host =
+      content::RenderViewHost::FromID(render_process_id, render_view_id);
+  content::WebContents* webContents =

[benm (inactive), 2013/01/07 10:45:02]

nit: web_contents

[Kristian Monsen, 2013/01/07 18:41:09]

Done.

+      content::WebContents::FromRenderViewHost(host);
+  AwContents* awContents = AwContents::FromWebContents(webContents);

[benm (inactive), 2013/01/07 10:45:02]

nit: aw_contents

[Kristian Monsen, 2013/01/07 18:41:09]

Done.

+  awContents->GeolocationShowPrompt(

[benm (inactive), 2013/01/07 10:45:02]

would ShowGeolocationPrompt be more readable?

[Kristian Monsen, 2013/01/07 18:41:09]

Public API is onGeolocationPermissionsShowPrompt:
http://developer.android.com/reference/android/webkit/WebChromeClient.html#on...,
android.webkit.GeolocationPermissions.Callback)

I wanted it to be as close as possible, but noticed that the On prefix was
frequently dropped in the chromium layer.

[joth, 2013/01/07 20:25:15]

Yep - onFoo in chromium is normally kept for Foo IPC message handlers.

But in AwContents we already have onReceivedHttpAuthRequest and
OnFindResultReceived and as that class is all about JNI bindings I think
reflecting the (invariant) java names is OK in places where we have a direct
mapping, like this.

(If we did't go that way, we should go more towards the chrome style and put the
verb first as per Ben comment.)

[Kristian Monsen, 2013/01/08 08:03:10]

Added On prefix

+      render_process_id,
+      render_view_id,
+      bridge_id,
+      requesting_frame);
+}
+
+void
+AwGeolocationPermissionContext::RequestGeolocationPermission(
+    int render_process_id,
+    int render_view_id,
+    int bridge_id,
+    const GURL& requesting_frame,
+    base::Callback<void(bool)> callback) {
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(
+          &AwGeolocationPermissionContext::
+              RequestGeolocationPermissionOnUIThread,
+          this,
+          render_process_id,
+          render_view_id,
+          bridge_id,
+          requesting_frame,
+          callback));
+}
+
+// static
+content::GeolocationPermissionContext*
+AwGeolocationPermissionContext::Create() {
+  return new AwGeolocationPermissionContext();
+}
+
+void
+AwGeolocationPermissionContext::CancelGeolocationPermissionRequestOnUIThread(
+    int render_process_id,
+    int render_view_id,
+    int bridge_id,
+    const GURL& requesting_frame) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  // TODO(kristianm): Implement this
+}
+
+void
+AwGeolocationPermissionContext::CancelGeolocationPermissionRequest(
+    int render_process_id,
+    int render_view_id,
+    int bridge_id,
+    const GURL& requesting_frame) {
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(
+          &AwGeolocationPermissionContext::
+              CancelGeolocationPermissionRequestOnUIThread,
+          this,
+          render_process_id,
+          render_view_id,
+          bridge_id,
+          requesting_frame));
+}
+
+void InvokeCallback(
+    int render_process_id,
+    int render_view_id,
+    int bridge_id,
+    const GURL& requesting_frame,
+    bool value) {

[benm (inactive), 2013/01/07 10:45:02]

nit: TODO?

[Kristian Monsen, 2013/01/08 08:03:10]

Done.

+}
+
+}  // namespace android_webview