Implementing native chromium GeolocationPermissionContext

android_webview/native/aw_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_H_
 #define ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_H_
 
 #include <jni.h>
 #include <string>
 
 #include "android_webview/browser/find_helper.h"
+#include "android_webview/native/aw_geolocation_permission_context.h"

[boliu_use_chromium_pls, 2013/01/04 23:45:43]

doesn't appear to be used

[Kristian Monsen, 2013/01/05 02:44:58]

Done.

 #include "android_webview/public/browser/draw_gl.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/android/jni_helper.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/android/compositor.h"
 #include "content/public/browser/javascript_dialogs.h"
 
 typedef void* EGLContext;
 class TabContents;
 
@@ skipping 73 matching lines @@
                                bool view_visible);
   void OnAttachedToWindow(JNIEnv* env, jobject obj, int w, int h);
   void OnDetachedFromWindow(JNIEnv* env, jobject obj);
   base::android::ScopedJavaLocalRef<jbyteArray> GetOpaqueState(
       JNIEnv* env, jobject obj);
   jboolean RestoreFromOpaqueState(JNIEnv* env, jobject obj, jbyteArray state);
   void SetScrollForHWFrame(JNIEnv* env, jobject obj,
                            int scroll_x, int scroll_y);
   void FocusFirstNode(JNIEnv* env, jobject obj);
 
+  // Geolocation API support
+  void GeolocationShowPrompt(int render_process_id, int render_view_id,
+                             int bridge_id, const GURL& requesting_frame);

[boliu_use_chromium_pls, 2013/01/04 23:45:43]

nit: I think in chromium c++ style guide
(http://dev.chromium.org/developers/coding-style), you have all arguments in one
line or each on different lines (and lined up)

[Kristian Monsen, 2013/01/05 02:44:58]

You are right, done. Almost every other function around there breaks that style
rule.

[boliu, 2013/01/05 04:37:35]

True...attribute it to differences between java and c++ style guide

+  void GeolocationHidePrompt();
+
   // Find-in-page API and related methods.
   jint FindAllSync(JNIEnv* env, jobject obj, jstring search_string);
   void FindAllAsync(JNIEnv* env, jobject obj, jstring search_string);
   void FindNext(JNIEnv* env, jobject obj, jboolean forward);
   void ClearMatches(JNIEnv* env, jobject obj);
   void ClearCache(JNIEnv* env, jobject obj, jboolean include_disk_files);
 
   FindHelper* GetFindHelper();
 
   // FindHelper::Listener implementation.
@@ skipping 38 matching lines @@
   EGLContext last_frame_context_;
 
   DISALLOW_COPY_AND_ASSIGN(AwContents);
 };
 
 bool RegisterAwContents(JNIEnv* env);
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_H_