src/objects-debug.cc - Issue 1176263004: Introduce a base pointer field in FixedTypedArrayBase and teach GC about it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 1176263004: Introduce a base pointer field in FixedTypedArrayBase and teach GC about it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 635bd6140ee177ecd7d4fdd77775971f33a99b67..d6765ddb09a33232dd14749f0608125458f68364 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -241,6 +241,7 @@ void FixedTypedArray<Traits>::FixedTypedArrayVerify() {

CHECK(IsHeapObject() &&

HeapObject::cast(this)->map()->instance_type() ==

Traits::kInstanceType);

+ CHECK(base_pointer() == this);

}

« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »