Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1176263004: Introduce a base pointer field in FixedTypedArrayBase and teach GC about it (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a base pointer field in FixedTypedArrayBase and teach GC about it This is the first step towards unifying external and on-heap typed arrays. The end-state will be that this base pointer either points to the on-heap values or to the externally allocated array buffer. BUG=v8:3996 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb Cr-Commit-Position: refs/heads/master@{#29039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -9 lines) Patch
M src/elements-kind.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-15 15:09:50 UTC) #1
Hannes Payer (out of office)
LGTM, please explain in the description what the base pointer will be used for.
5 years, 6 months ago (2015-06-16 07:32:09 UTC) #2
jochen (gone - plz use gerrit)
done
5 years, 6 months ago (2015-06-16 07:35:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176263004/1
5 years, 6 months ago (2015-06-16 07:35:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 07:37:21 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 07:37:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cc3eb66a2b1b0885852c5ae3a58a4c3802d11fb
Cr-Commit-Position: refs/heads/master@{#29039}

Powered by Google App Engine
This is Rietveld 408576698