components/precache/content/precache_manager_unittest.cc - Issue 1176253002: Fix IsPrecachingAllowed() to check Sync instead of Data Saver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/precache/content/precache_manager_unittest.cc

Issue 1176253002: Fix IsPrecachingAllowed() to check Sync instead of Data Saver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use active rather than preferred, per zea@. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/precache/content/precache_manager_unittest.cc

diff --git a/components/precache/content/precache_manager_unittest.cc b/components/precache/content/precache_manager_unittest.cc

index 6f5fd89c6dbd53798940b431484705cf35d3bc2e..b0ed8d80f33d80178086ece55d64f7bdc74a64d9 100644

--- a/components/precache/content/precache_manager_unittest.cc

+++ b/components/precache/content/precache_manager_unittest.cc

@@ -124,9 +124,10 @@ class TestPrecacheCompletionCallback {

class PrecacheManagerTest : public testing::Test {

public:

PrecacheManagerTest()

- : precache_manager_(&browser_context_),

- factory_(NULL, base::Bind(&TestURLFetcherCallback::CreateURLFetcher,

- base::Unretained(&url_callback_))) {}

+ : precache_manager_(&browser_context_, nullptr /* sync_service */),

+ factory_(NULL,

bengr 2015/06/23 22:16:19 Mind changing this to nullptr too?

twifkak 2015/06/23 23:54:51 Not at all. Done.

+ base::Bind(&TestURLFetcherCallback::CreateURLFetcher,

+ base::Unretained(&url_callback_))) {}

protected:

void SetUp() override {

« components/precache/content/precache_manager.cc ('K') | « components/precache/content/precache_manager_factory.cc ('k') | no next file » | no next file with comments »