Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: Source/modules/fetch/FetchDataConsumerHandle.h

Issue 1176243004: Add FetchDataConsumerHandle and utility functions/classes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Build break fix. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/fetch/DataConsumerHandleUtilTest.cpp ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/fetch/FetchDataConsumerHandle.h
diff --git a/Source/modules/fetch/FetchDataConsumerHandle.h b/Source/modules/fetch/FetchDataConsumerHandle.h
new file mode 100644
index 0000000000000000000000000000000000000000..76078067216f130831ede82bd0f0a74466824aad
--- /dev/null
+++ b/Source/modules/fetch/FetchDataConsumerHandle.h
@@ -0,0 +1,49 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef FetchDataConsumerHandle_h
+#define FetchDataConsumerHandle_h
+
+#include "platform/blob/BlobData.h"
+#include "public/platform/WebDataConsumerHandle.h"
+#include "wtf/Forward.h"
+#include "wtf/PassRefPtr.h"
+
+namespace blink {
+
+// This is an interface class that adds Reader's blobDataHandle() to
+// WebDataConsumerHandle.
+// This class works not very well with Oilpan: As this class is not garbage
+// collected while many clients or related objects may be, it is very easy
+// to create a reference cycle. When an client is garbage collected, making
+// the client own the handle is the right way.
+class FetchDataConsumerHandle : public WebDataConsumerHandle {
+public:
+ class Reader : public WebDataConsumerHandle::Reader {
+ public:
+ // Drains the data as a BlobDataHandle.
+ // If this function returns non-null BlobDataHandle:
+ // - The bytes that will be read from the returned BlobDataHandle
+ // must be idential to the bytes that would be read through
+ // WebDataConsumerHandle::Reader APIs without calling this function.
+ // - Subsequent calls to read() / beginRead() returns |Done|.
+ // - The returned blob handle has a valid size (i.e. != kuint64max).
+ // This function can return |nullptr|, and in such cases this
+ // functions is no-op.
+ // This function returns |nullptr| when called during two-phase read.
+ virtual PassRefPtr<BlobDataHandle> drainAsBlobDataHandle() { return nullptr; }
+ };
+
+ // TODO(yhirano): obtainReader() is currently non-virtual override, and
+ // will be changed into virtual override when we can use scoped_ptr /
+ // unique_ptr in both Blink and Chromium.
+ PassOwnPtr<Reader> obtainReader(Client* client) { return adoptPtr(obtainReaderInternal(client)); }
+
+private:
+ Reader* obtainReaderInternal(Client*) override = 0;
+};
+
+} // namespace blink
+
+#endif // FetchDataConsumerHandle_h
« no previous file with comments | « Source/modules/fetch/DataConsumerHandleUtilTest.cpp ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698