Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(224)

Issue 1176223002: [tracing] Clean up the MemoryInfra API surface (3/3) (Closed)

Created:
4 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
pdr., Rick Byers
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Clean up the MemoryInfra API surface (3/3) This patch simplifies the API surface of MemoryInfra switching attribute names from std::string to char*. The main goal is to make the dumping fast and predictable memory-wise. There is no point allowing the attribute names to be arbitrary strings (read non static "quoted" char* ptrs). That has the only effect of causing loads of copies and std::string ctors / dtors. BUG=495628, 480500 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M public/platform/WebMemoryAllocatorDump.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Primiano Tucci (use gerrit)
Follows from crrev.com/1173253002, see my message there.
4 years, 10 months ago (2015-06-11 00:48:28 UTC) #2
Rick Byers
lgtm
4 years, 10 months ago (2015-06-11 01:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176223002/1
4 years, 10 months ago (2015-06-11 12:45:39 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 14:57:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196952

Powered by Google App Engine
This is Rietveld 408576698