chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 11762004: Make favicons for about:history and about:bookmarks switch from lodpi to hidpi when dragging browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 11762004: Make favicons for about:history and about:bookmarks switch from lodpi to hidpi when dragging browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/home_page_overlay.js ('k') | chrome/browser/resources/shared/js/util.js » ('j') | chrome/browser/resources/shared/js/util.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 5d5a571200df38f3b24a6d5999e655e89891ec15..71f3c2139bca64a52d1df8f5504d726d5b7a68e3 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -99,9 +99,7 @@ cr.define('options.search_engines', function() {

var faviconDivEl = this.ownerDocument.createElement('div');

faviconDivEl.className = 'favicon';

if (!this.isPlaceholder) {

- faviconDivEl.style.backgroundImage =

- url('chrome://favicon/iconurl@' + window.devicePixelRatio + 'x/' +

- engine.iconURL);

kevers 2013/01/04 20:21:10 Has this change been thoroughly tested? It appears

pkotwicz 2013/01/04 21:21:39 Thanks for catching this Kevin! chrome://favicon/i

+ faviconDivEl.style.backgroundImage = getFaviconImageSet(engine.iconURL);

}

nameColEl.appendChild(faviconDivEl);