Make favicons for about:history and about:bookmarks switch from lodpi to hidpi when dragging browser

chrome/browser/resources/options/search_engine_manager_engine_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.search_engines', function() {
   /** @const */ var ControlledSettingIndicator =
                     options.ControlledSettingIndicator;
   /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
   /** @const */ var InlineEditableItem = options.InlineEditableItem;
   /** @const */ var ListSelectionController = cr.ui.ListSelectionController;
@@ skipping 81 matching lines @@
       // Construct the name column.
       var nameColEl = this.ownerDocument.createElement('div');
       nameColEl.className = 'name-column';
       nameColEl.classList.add('weakrtl');
       this.contentElement.appendChild(nameColEl);
 
       // Add the favicon.
       var faviconDivEl = this.ownerDocument.createElement('div');
       faviconDivEl.className = 'favicon';
       if (!this.isPlaceholder) {
-        faviconDivEl.style.backgroundImage =
-            url('chrome://favicon/iconurl@' + window.devicePixelRatio + 'x/' +
-                engine.iconURL);

[kevers, 2013/01/04 20:21:10]

Has this change been thoroughly tested? It appears that components in the image
set will be missing the iconurl portion, which may be problematic.  Perhaps the
trailing optional parameter in getFaviconImageSet for denoting a session favicon
should be an optional string type to allow handling of 'favicon',
'session-favicon' and 'favicon/iconurl'.

[pkotwicz, 2013/01/04 21:21:39]

Thanks for catching this Kevin! chrome://favicon/iconurl does have different
behavior

+        faviconDivEl.style.backgroundImage = getFaviconImageSet(engine.iconURL);
       }
       nameColEl.appendChild(faviconDivEl);
 
       var nameEl = this.createEditableTextCell(engine.displayName);
       nameEl.classList.add('weakrtl');
       nameColEl.appendChild(nameEl);
 
       // Then the keyword column.
       var keywordEl = this.createEditableTextCell(engine.keyword);
       keywordEl.className = 'keyword-column';
@@ skipping 204 matching lines @@
     },
   };
 
   // Export
   return {
     SearchEngineList: SearchEngineList
   };
 
 });