Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1176163004: Revert of Promise assimilation fix. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/1098663002/) Reason for revert: Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829 Original issue's description: > Promise assimilation fix. > > Let x be a fulfilled promise and y be another promise. |x.then(() => y)| > should call |y.then|, but the current implementation calls PromiseChain. > We can see the difference when we set a custom function to |y.then|. > > This CL fixes the spec violation, but as a result |then| is no longer > a wrapper of |chain| and in some cases it does not work well with > |accept| or |chain|. That is not a problem for ES6 promise users because > ES6 promise doesn't have them. > > LOG=N > BUG=477921 > > Committed: https://crrev.com/2f57dff3ea0c45e1a61b334fda962460f89d71bc > Cr-Commit-Position: refs/heads/master@{#28926} TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477921 Committed: https://crrev.com/5bb75f514027f79303396dba823c2d78c6add83b Cr-Commit-Position: refs/heads/master@{#28927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -231 lines) Patch
M src/promise.js View 6 chunks +40 lines, -78 lines 0 comments Download
M test/mjsunit/es6/promises.js View 2 chunks +0 lines, -153 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of Promise assimilation fix.
5 years, 6 months ago (2015-06-11 08:00:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176163004/1
5 years, 6 months ago (2015-06-11 08:01:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 08:01:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5bb75f514027f79303396dba823c2d78c6add83b Cr-Commit-Position: refs/heads/master@{#28927}
5 years, 6 months ago (2015-06-11 08:01:26 UTC) #4
Yang
5 years, 6 months ago (2015-06-11 08:15:00 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1181533006/ by yangguo@chromium.org.

The reason for reverting is: Test failures are bogus. Snapshot blob and natives
blob are out of sync due to build being weird..

Powered by Google App Engine
This is Rietveld 408576698