Issue 1176153006: Componentize ShortcutsBackend

Issue 1176153006: Componentize ShortcutsBackend (Closed)

Created:
5 years, 6 months ago by blundell

Modified:
5 years, 6 months ago

Reviewers:
Mike Lerman, Peter Kasting

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@shortcuts_backend_dependency_injection

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Componentize ShortcutsBackend No changes are needed. TBR=mlerman Committed: https://crrev.com/3bf9496e484b3c40e08ab3391cbf940e7c2098af Cr-Commit-Position: refs/heads/master@{#335250}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -509 lines)			Patch
D	chrome/browser/autocomplete/shortcuts_backend.h	View	1	1 chunk	+0 lines, -174 lines	0 comments	Download
D	chrome/browser/autocomplete/shortcuts_backend.cc	View	1	1 chunk	+0 lines, -321 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_backend_factory.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_backend_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_extensions_manager.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_navigation_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/omnibox.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/omnibox/BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	components/omnibox/shortcuts_backend.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/omnibox/shortcuts_backend.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (4 generated)

blundell

TBR=mlerman for //chrome/browser/profiles/profile_impl.cc

5 years, 6 months ago (2015-06-19 11:57:37 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176153006/20001

5 years, 6 months ago (2015-06-19 12:45:49 UTC) #9

commit-bot: I haz the power

5 years, 6 months ago (2015-06-19 13:07:43 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3bf9496e484b3c40e08ab3391cbf940e7c2098af
Cr-Commit-Position: refs/heads/master@{#335250}