Chromium Code Reviews| Index: tests_lit/llvm2ice_tests/function_aligned.ll |
| diff --git a/tests_lit/llvm2ice_tests/function_aligned.ll b/tests_lit/llvm2ice_tests/function_aligned.ll |
| index 23d2ca75ea465335aa5929f6cb9f83a8a1a14caf..cbe4985878f156f5fe2a6281f1bc418bcf9dce51 100644 |
| --- a/tests_lit/llvm2ice_tests/function_aligned.ll |
| +++ b/tests_lit/llvm2ice_tests/function_aligned.ll |
| @@ -13,6 +13,9 @@ |
| ; RUN: --disassemble --target arm32 -i %s --args -O2 --skip-unimplemented \ |
| ; RUN: | %if --need=target_ARM32 --need=allow_dump \ |
| ; RUN: --command FileCheck --check-prefix ARM32 %s |
| +; RUN: %if --need=target_MIPS32 --command %p2i --filetype=asm --assemble \ |
|
jvoung (off chromium)
2015/07/07 18:02:35
Can you add the "--need=allow_dump " that is now p
reed.kotler
2015/07/08 02:05:17
Done.
|
| +; RUN: --disassemble --target mips32 -i %s --args -O2 --skip-unimplemented \ |
| +; RUN: | %if --need=target_MIPS32 --command FileCheck --check-prefix MIPS32 %s |
|
jvoung (off chromium)
2015/07/07 18:02:35
this line also requires a "--need=allow_dump" befo
reed.kotler
2015/07/08 02:05:17
Done.
|
| define void @foo() { |
| ret void |
| @@ -25,6 +28,11 @@ define void @foo() { |
| ; ARM32-NEXT: 4: e7fedef0 udf |
| ; ARM32-NEXT: 8: e7fedef0 udf |
| ; ARM32-NEXT: c: e7fedef0 udf |
| +; TODO (Reed Kotler check this disassembly, .s file looks fine) |
|
jvoung (off chromium)
2015/07/07 18:02:35
"TODO(reed kotler)" for consistency
Or just leave
reed.kotler
2015/07/08 02:05:17
Done.
|
| +; MIPS32-LABEL: foo |
| +; MIPS32: 4: {{.*}} jr ra |
| +; MIPS32-NEXT: 8: {{.*}} nop |
| +; MIPS32-NEXT: c: e7fedef0 |
|
jvoung (off chromium)
2015/07/07 18:02:35
I think the main TODO is that "e7fedef0" is an "un
reed.kotler
2015/07/07 21:54:55
Done.
|
| define void @bar() { |
| ret void |
| @@ -33,3 +41,7 @@ define void @bar() { |
| ; CHECK-NEXT: 20: {{.*}} ret |
| ; ARM32-LABEL: bar |
| ; ARM32-NEXT: 10: {{.*}} bx lr |
| +; TOOD (Reed Kotler check this disassembly, .s file looks fine) |
|
jvoung (off chromium)
2015/07/07 18:02:35
Probably don't need a TODO, since this block doesn
reed.kotler
2015/07/07 21:54:55
Done.
jvoung (off chromium)
2015/07/08 00:39:11
Doesn't appear to be removed?
reed.kotler
2015/07/08 02:05:17
Done.
|
| +; MIPS32-LABEL: bar |
| +; MIPS32: 14: {{.*}} jr ra |
| +; MIPS32-NEXT: 18: {{.*}} nop |