 Chromium Code Reviews
 Chromium Code Reviews Issue 1176133004:
  implement the null function for the Mips32 subzero compiler  (Closed) 
  Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
    
  
    Issue 1176133004:
  implement the null function for the Mips32 subzero compiler  (Closed) 
  Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master| Index: src/IceAssemblerMIPS32.h | 
| diff --git a/src/IceAssemblerMIPS32.h b/src/IceAssemblerMIPS32.h | 
| index b088d5693bcd54e640532a35e3393328dbc84e0e..b777b7af1e12b899a8474f05d0907a87de9671cf 100644 | 
| --- a/src/IceAssemblerMIPS32.h | 
| +++ b/src/IceAssemblerMIPS32.h | 
| @@ -49,10 +49,12 @@ public: | 
| SizeT getBundleAlignLog2Bytes() const override { return 4; } | 
| - const char *getNonExecPadDirective() const override { return ".TBD"; } | 
| + const char *getNonExecPadDirective() const override { return ".p2alignl"; } | 
| llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override { | 
| - llvm::report_fatal_error("Not yet implemented."); | 
| + // TBD (Reed Kotler ) . Find out what this should be. | 
| 
jvoung (off chromium)
2015/07/07 18:02:34
Please use a more consistent TODO marker for grepp
 
reed.kotler
2015/07/07 21:54:54
Done.
 | 
| + static const uint8_t Padding[] = {0xE7, 0xFE, 0xDE, 0xF0}; | 
| + return llvm::ArrayRef<uint8_t>(Padding, 4); | 
| } | 
| void padWithNop(intptr_t Padding) override { |