Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: pydir/run-pnacl-sz.py

Issue 1176133004: implement the null function for the Mips32 subzero compiler (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fixing patch per review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pydir/run-pnacl-sz.py
diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py
index 787910cc532a0efff3f291aaa776688bc2a780ef..72b6a0be9aab1e572caccd22fd3d932d4aae3a91 100755
--- a/pydir/run-pnacl-sz.py
+++ b/pydir/run-pnacl-sz.py
@@ -15,14 +15,18 @@ def TargetAssemblerFlags(target):
# TODO(stichnot): -triple=i686-nacl should be used for a
# sandboxing test. This means there should be an args.sandbox
# argument that also gets passed through to pnacl-sz.
+ # TODO(reed kotler). Need to find out exactly we need to
+ # add here for Mips32.
flags = { 'x8632': ['-triple=i686'],
- 'arm32': ['-triple=armv7a', '-mcpu=cortex-a9', '-mattr=+neon'] }
+ 'arm32': ['-triple=armv7a', '-mcpu=cortex-a9', '-mattr=+neon'],
+ 'mips32': ['-triple=mipsel-none-nacl' ] }
return flags[target]
def TargetDisassemblerFlags(target):
flags = { 'x8632': ['-Mintel'],
- 'arm32': [] }
+ 'arm32': [],
+ 'mips32':[] }
return flags[target]
@@ -73,7 +77,7 @@ def main():
choices=['obj', 'asm', 'iasm'],
help='Output file type. Default %(default)s.')
argparser.add_argument('--target', default='x8632', dest='target',
- choices=['x8632','arm32'],
+ choices=['x8632','arm32','mips32'],
help='Target architecture. Default %(default)s.')
argparser.add_argument('--echo-cmd', required=False,
action='store_true',

Powered by Google App Engine
This is Rietveld 408576698