Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Side by Side Diff: tests_lit/llvm2ice_tests/function_aligned.ll

Issue 1176133004: implement the null function for the Mips32 subzero compiler (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Address code review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/IceAssemblerMIPS32.h ('K') | « src/IceTargetLoweringMIPS32.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 ; Test that functions are aligned to the NaCl bundle alignment. 1 ; Test that functions are aligned to the NaCl bundle alignment.
2 ; We could be smarter and only do this for indirect call targets 2 ; We could be smarter and only do this for indirect call targets
3 ; but typically you want to align functions anyway. 3 ; but typically you want to align functions anyway.
4 ; Also, we are currently using hlts for non-executable padding. 4 ; Also, we are currently using hlts for non-executable padding.
5 5
6 ; RUN: %p2i --filetype=obj --disassemble -i %s --args -O2 | FileCheck %s 6 ; RUN: %p2i --filetype=obj --disassemble -i %s --args -O2 | FileCheck %s
7 7
8 ; TODO(jvoung): Stop skipping unimplemented parts (via --skip-unimplemented) 8 ; TODO(jvoung): Stop skipping unimplemented parts (via --skip-unimplemented)
9 ; once enough infrastructure is in. Also, switch to --filetype=obj 9 ; once enough infrastructure is in. Also, switch to --filetype=obj
10 ; when possible. 10 ; when possible.
11 ; RUN: %if --need=target_ARM32 --need=allow_dump \ 11 ; RUN: %if --need=target_ARM32 --need=allow_dump \
12 ; RUN: --command %p2i --filetype=asm --assemble \ 12 ; RUN: --command %p2i --filetype=asm --assemble \
13 ; RUN: --disassemble --target arm32 -i %s --args -O2 --skip-unimplemented \ 13 ; RUN: --disassemble --target arm32 -i %s --args -O2 --skip-unimplemented \
14 ; RUN: | %if --need=target_ARM32 --need=allow_dump \ 14 ; RUN: | %if --need=target_ARM32 --need=allow_dump \
15 ; RUN: --command FileCheck --check-prefix ARM32 %s 15 ; RUN: --command FileCheck --check-prefix ARM32 %s
16 ; RUN: %if --need=target_MIPS32 --need=allow_dump --command %p2i --filetype=asm --assemble \
jvoung (off chromium) 2015/07/08 00:39:12 Since there is "\" at the end of the line to wrap
17 ; RUN: --disassemble --target mips32 -i %s --args -O2 --skip-unimplemented \
18 ; RUN: | %if --need=target_MIPS32 --need=allow_dump --command FileCheck --chec k-prefix MIPS32 %s
jvoung (off chromium) 2015/07/08 00:39:12 similar, could wrap earlier
16 19
17 define void @foo() { 20 define void @foo() {
18 ret void 21 ret void
19 } 22 }
20 ; CHECK-LABEL: foo 23 ; CHECK-LABEL: foo
21 ; CHECK-NEXT: 0: {{.*}} ret 24 ; CHECK-NEXT: 0: {{.*}} ret
22 ; CHECK-NEXT: 1: {{.*}} hlt 25 ; CHECK-NEXT: 1: {{.*}} hlt
23 ; ARM32-LABEL: foo 26 ; ARM32-LABEL: foo
24 ; ARM32-NEXT: 0: {{.*}} bx lr 27 ; ARM32-NEXT: 0: {{.*}} bx lr
25 ; ARM32-NEXT: 4: e7fedef0 udf 28 ; ARM32-NEXT: 4: e7fedef0 udf
26 ; ARM32-NEXT: 8: e7fedef0 udf 29 ; ARM32-NEXT: 8: e7fedef0 udf
27 ; ARM32-NEXT: c: e7fedef0 udf 30 ; ARM32-NEXT: c: e7fedef0 udf
31 ; MIPS32-LABEL: foo
32 ; MIPS32: 4: {{.*}} jr ra
33 ; MIPS32-NEXT: 8: {{.*}} nop
34 ; MIPS32-NEXT: c: e7fedef0
35 ; TODO (reed kotler check this disassembly, .s file looks fine)
jvoung (off chromium) 2015/07/08 00:39:12 "TODO (reed kotler" -> "TODO(reed kotler)"
36 ; "e7fedef0" is an "undefined"/halting instruction for ARM (what llvm.trap would translate to)
28 37
29 define void @bar() { 38 define void @bar() {
30 ret void 39 ret void
31 } 40 }
32 ; CHECK-LABEL: bar 41 ; CHECK-LABEL: bar
33 ; CHECK-NEXT: 20: {{.*}} ret 42 ; CHECK-NEXT: 20: {{.*}} ret
34 ; ARM32-LABEL: bar 43 ; ARM32-LABEL: bar
35 ; ARM32-NEXT: 10: {{.*}} bx lr 44 ; ARM32-NEXT: 10: {{.*}} bx lr
45 ; TOOD (Reed Kotler check this disassembly, .s file looks fine)
46 ; MIPS32-LABEL: bar
47 ; MIPS32: 14: {{.*}} jr ra
48 ; MIPS32-NEXT: 18: {{.*}} nop
OLDNEW
« src/IceAssemblerMIPS32.h ('K') | « src/IceTargetLoweringMIPS32.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698