 Chromium Code Reviews
 Chromium Code Reviews Issue 1176133004:
  implement the null function for the Mips32 subzero compiler  (Closed) 
  Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
    
  
    Issue 1176133004:
  implement the null function for the Mips32 subzero compiler  (Closed) 
  Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master| OLD | NEW | 
|---|---|
| 1 //===- subzero/src/assembler_mips.h - Assembler for MIPS --------*- C++ -*-===// | 1 //===- subzero/src/assembler_mips.h - Assembler for MIPS --------*- C++ -*-===// | 
| 2 // | 2 // | 
| 3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 
| 4 // for details. All rights reserved. Use of this source code is governed by a | 4 // for details. All rights reserved. Use of this source code is governed by a | 
| 5 // BSD-style license that can be found in the LICENSE file. | 5 // BSD-style license that can be found in the LICENSE file. | 
| 6 // | 6 // | 
| 7 // Modified by the Subzero authors. | 7 // Modified by the Subzero authors. | 
| 8 // | 8 // | 
| 9 //===----------------------------------------------------------------------===// | 9 //===----------------------------------------------------------------------===// | 
| 10 // | 10 // | 
| (...skipping 29 matching lines...) Expand all Loading... | |
| 40 (void)use_far_branches; | 40 (void)use_far_branches; | 
| 41 } | 41 } | 
| 42 ~AssemblerMIPS32() override = default; | 42 ~AssemblerMIPS32() override = default; | 
| 43 | 43 | 
| 44 void alignFunction() override { | 44 void alignFunction() override { | 
| 45 llvm::report_fatal_error("Not yet implemented."); | 45 llvm::report_fatal_error("Not yet implemented."); | 
| 46 } | 46 } | 
| 47 | 47 | 
| 48 SizeT getBundleAlignLog2Bytes() const override { return 4; } | 48 SizeT getBundleAlignLog2Bytes() const override { return 4; } | 
| 49 | 49 | 
| 50 const char *getNonExecPadDirective() const override { return ".TBD"; } | 50 const char *getNonExecPadDirective() const override { return ".p2alignl"; } | 
| 51 | 51 | 
| 52 llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override { | 52 llvm::ArrayRef<uint8_t> getNonExecBundlePadding() const override { | 
| 53 llvm::report_fatal_error("Not yet implemented."); | 53 // TBD (Reed Kotler ) . Find out what this should be. | 
| 
jvoung (off chromium)
2015/06/12 19:39:12
nit: Usually we try to format the "TODO"s consiste
 | |
| 54 static const uint8_t Padding[] = {0xE7, 0xFE, 0xDE, 0xF0}; | |
| 55 return llvm::ArrayRef<uint8_t>(Padding, 4); | |
| 54 } | 56 } | 
| 55 | 57 | 
| 56 void padWithNop(intptr_t Padding) override { | 58 void padWithNop(intptr_t Padding) override { | 
| 57 (void)Padding; | 59 (void)Padding; | 
| 58 llvm::report_fatal_error("Not yet implemented."); | 60 llvm::report_fatal_error("Not yet implemented."); | 
| 59 } | 61 } | 
| 60 | 62 | 
| 61 void bindCfgNodeLabel(SizeT NodeNumber) override { | 63 void bindCfgNodeLabel(SizeT NodeNumber) override { | 
| 62 (void)NodeNumber; | 64 (void)NodeNumber; | 
| 63 llvm::report_fatal_error("Not yet implemented."); | 65 llvm::report_fatal_error("Not yet implemented."); | 
| 64 } | 66 } | 
| 65 | 67 | 
| 66 bool fixupIsPCRel(FixupKind Kind) const override { | 68 bool fixupIsPCRel(FixupKind Kind) const override { | 
| 67 (void)Kind; | 69 (void)Kind; | 
| 68 llvm::report_fatal_error("Not yet implemented."); | 70 llvm::report_fatal_error("Not yet implemented."); | 
| 69 } | 71 } | 
| 70 }; | 72 }; | 
| 71 | 73 | 
| 72 } // end of namespace MIPS32 | 74 } // end of namespace MIPS32 | 
| 73 } // end of namespace Ice | 75 } // end of namespace Ice | 
| 74 | 76 | 
| 75 #endif // SUBZERO_SRC_ASSEMBLER_MIPS32_H | 77 #endif // SUBZERO_SRC_ASSEMBLER_MIPS32_H | 
| OLD | NEW |