Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(166)

Issue 1176133003: DevTools: deflake extensions-resources.html (Closed)

Created:
4 years, 10 months ago by caseq
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: deflake extensions-resources.html There is a race between loading network resources in page and loading front-end and enabling ResourceAgent, so load resources of interest after we start the test and only white-list resources that we're sure to be present. BUG=498539 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197027

Patch Set 1 : #

Total comments: 1

Patch Set 2 : extracted loaded resources into an iframe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M LayoutTests/http/tests/inspector/resources/extension-main.js View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-resources.html View 1 6 chunks +15 lines, -9 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-resources-expected.txt View 1 3 chunks +7 lines, -18 lines 0 comments Download
A LayoutTests/inspector/extensions/resources/subframe.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/inspector/extensions/resources/test-script.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
caseq
4 years, 10 months ago (2015-06-11 15:28:33 UTC) #3
dgozman
https://codereview.chromium.org/1176133003/diff/20001/LayoutTests/inspector/extensions/extensions-resources.html File LayoutTests/inspector/extensions/extensions-resources.html (right): https://codereview.chromium.org/1176133003/diff/20001/LayoutTests/inspector/extensions/extensions-resources.html#newcode73 LayoutTests/inspector/extensions/extensions-resources.html:73: var resourceURLsWhiteList = ["abe.png", "audits-style1.css", "test-script.js"]; Can we add ...
4 years, 10 months ago (2015-06-11 15:50:52 UTC) #4
caseq
On 2015/06/11 15:50:52, dgozman wrote: > https://codereview.chromium.org/1176133003/diff/20001/LayoutTests/inspector/extensions/extensions-resources.html > File LayoutTests/inspector/extensions/extensions-resources.html (right): > > https://codereview.chromium.org/1176133003/diff/20001/LayoutTests/inspector/extensions/extensions-resources.html#newcode73 > ...
4 years, 10 months ago (2015-06-11 16:15:40 UTC) #5
dgozman
lgtm
4 years, 10 months ago (2015-06-11 21:06:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176133003/40001
4 years, 10 months ago (2015-06-12 09:18:04 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 10:37:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197027

Powered by Google App Engine
This is Rietveld 408576698