Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(89)

Issue 1176113004: Revert 196930 "Window.postMessage() to self can cause document l..." (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
landell
CC:
blink-reviews
Visibility:
Public.

Description

Revert 196930 "Window.postMessage() to self can cause document l..." Caused crashes in blink::PostMessageTimer::fired. See https://code.google.com/p/chromium/issues/detail?id=499692 for more details. > Window.postMessage() to self can cause document leaks > > When a script does Window.postMessage() a PostMessageTimer object is > stored in the LocalDOMWindow until the message has been delivered, or > until it is cleared in the destructor of LocalDOMWindow. When a > LocalDOMWindow is reset the remaining messages will not be > delivered. Any PostMessageTimer objects alive at that point will be > kept until the LocalDOMWindow is destroyed. Unfortunately, the > PostMessageTimer objects keeps a reference to the source window. If > both the source and destination window of the message is the same, the > PostMessageTimer can keep that LocalDOMWindow from getting destroyed. > > Removing the PostMessageTimers when stop() is invoked fixes the problem. > > BUG= > > Review URL: https://codereview.chromium.org/1148133005 TBR=landell@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -54 lines) Patch
D trunk/LayoutTests/fast/dom/Window/post-message-to-self.html View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/LayoutTests/fast/dom/Window/post-message-to-self-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/Source/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/frame/LocalDOMWindow.cpp View 4 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
4 years, 10 months ago (2015-06-12 07:24:28 UTC) #1
haraken
4 years, 10 months ago (2015-06-12 07:24:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r197009.

Powered by Google App Engine
This is Rietveld 408576698