Issue 11761032: Shows the notification icon during the login session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11761032: Shows the notification icon during the login session. (Closed)

Created:
7 years, 11 months ago by Jun Mukai

Modified:
7 years, 11 months ago

Reviewers:
stevenjb, jennyz

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, miket_OOO

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Shows the notification icon during the login session. BUG=166786 TEST=login and see if the shelf has the notification icon even though there're no notifications. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175647

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	ash/system/web_notification/web_notification_tray.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

stevenjb

LGTM, assuming we've confirmed that UpdateAfterLoginStatusChange() always gets called after construction (i.e. even after a ...

7 years, 11 months ago (2013-01-08 00:11:01 UTC) #2

Jun Mukai

On 2013/01/08 00:11:01, stevenjb (chromium) wrote: > LGTM, assuming we've confirmed that UpdateAfterLoginStatusChange() always gets ...

7 years, 11 months ago (2013-01-08 00:36:07 UTC) #3

commit-bot: I haz the power

7 years, 11 months ago (2013-01-08 00:38:40 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11761032/1