Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 11761032: Shows the notification icon during the login session. (Closed)

Created:
7 years, 11 months ago by Jun Mukai
Modified:
7 years, 11 months ago
Reviewers:
stevenjb, jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, miket_OOO
Visibility:
Public.

Description

Shows the notification icon during the login session. BUG=166786 TEST=login and see if the shelf has the notification icon even though there're no notifications. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ash/system/web_notification/web_notification_tray.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
7 years, 11 months ago (2013-01-04 02:12:35 UTC) #1
stevenjb
LGTM, assuming we've confirmed that UpdateAfterLoginStatusChange() always gets called after construction (i.e. even after a ...
7 years, 11 months ago (2013-01-08 00:11:01 UTC) #2
Jun Mukai
On 2013/01/08 00:11:01, stevenjb (chromium) wrote: > LGTM, assuming we've confirmed that UpdateAfterLoginStatusChange() always gets ...
7 years, 11 months ago (2013-01-08 00:36:07 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 00:38:40 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698