 Chromium Code Reviews
 Chromium Code Reviews Issue 11761030:
  Create the crash key registration system and register some Mac-specific keys.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 11761030:
  Create the crash key registration system and register some Mac-specific keys.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/common/crash_keys.cc | 
| diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc | 
| index 55b0864c40e0fab3b81d8c0a2b9e7f35d07cd458..ad413d18dbcf6171822681fefc037eaf653e363e 100644 | 
| --- a/chrome/common/crash_keys.cc | 
| +++ b/chrome/common/crash_keys.cc | 
| @@ -6,6 +6,36 @@ | 
| namespace crash_keys { | 
| +// TODO(rsesek): This is true on Mac and Linux but not Windows. | 
| +static const size_t kSingleChunkLength = 255; | 
| + | 
| +size_t RegisterChromeCrashKeys() { | 
| + base::debug::CrashKey keys[] = { | 
| + // TODO(rsesek): Remove when done testing. Needed so arraysize > 0. | 
| 
Mark Mentovai
2013/01/15 21:31:03
If the arraysize > 0 bit is really important, put
 
Robert Sesek
2013/01/15 21:40:50
This is get around a compiler error from ArraySize
 | 
| + { "rsesek_key", 1 }, | 
| +#if defined(OS_MACOSX) | 
| + { mac::kFirstNSException, 1 }, | 
| + { mac::kFirstNSExceptionTrace, 1 }, | 
| + { mac::kLastNSException, 1 }, | 
| + { mac::kLastNSExceptionTrace, 1 }, | 
| + { mac::kNSException, 1 }, | 
| + { mac::kSendAction, 1 }, | 
| + { mac::kZombie, 1 }, | 
| + { mac::kZombieTrace, 1 }, | 
| + // content/: | 
| + { "channel_error_bt", 1 }, | 
| + { "remove_route_bt", 1 }, | 
| + { "rwhvm_window", 1 }, | 
| + // media/: | 
| + { "VideoCaptureDeviceQTKit", 1 }, | 
| +#endif | 
| + }; | 
| + | 
| + return base::debug::InitCrashKeys(keys, arraysize(keys), kSingleChunkLength); | 
| +} | 
| + | 
| +// Crash Key Name Constants //////////////////////////////////////////////////// | 
| 
brettw
2013/01/15 21:19:17
I wouldn't do this comment since the file is small
 
Robert Sesek
2013/01/15 21:40:50
Done.
 | 
| + | 
| namespace mac { | 
| const char kFirstNSException[] = "firstexception"; |