When launching PNaCl helper nexes, explicitly disable IRT loading.

ppapi/api/private/ppb_nacl_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* This file contains NaCl private interfaces. */
 
 #inline c
 #include "ppapi/c/private/pp_file_handle.h"
 #endinl
@@ skipping 26 matching lines @@
 
 /* PPB_NaCl_Private */
 interface PPB_NaCl_Private {
   /* Launches NaCl's sel_ldr process.  Returns PP_NACL_OK on success and writes
    * |socket_count| nacl::Handles to imc_handles. Returns PP_NACL_FAILED on
    * failure. The |enable_ppapi_dev| parameter controls whether GetInterface
    * returns 'Dev' interfaces to the NaCl plugin.  The |uses_ppapi| flag
    * indicates that the nexe run by sel_ldr will use the PPAPI APIs.
    * This implies that LaunchSelLdr is run from the main thread.  If a nexe
    * does not need PPAPI, then it can run off the main thread.
+   * The |uses_irt| flag indicates if a nexe depends on the IRT or not.

[Mark Seaborn, 2013/01/04 00:05:41]

Maybe "...indicates whether the IRT should be loaded in this NaCl process"?

[jvoung (off chromium), 2013/01/04 17:09:23]

Done.

+   * This is true for ABI stable nexes.
    */
   PP_NaClResult LaunchSelLdr([in] PP_Instance instance,
                              [in] str_t alleged_url,
                              [in] PP_Bool uses_ppapi,
                              [in] PP_Bool enable_ppapi_dev,
                              [in] int32_t socket_count,

[Mark Seaborn, 2013/01/04 00:05:41]

Can you keep socket_count and imc_handles together?  You can put uses_irt next
to the other PP_Bools.

I'd put "uses_irt" earlier in the argument list, before "uses_ppapi" (since
that's only temporary) and before "enable_ppapi_dev" (since it's only a dev
option).

[jvoung (off chromium), 2013/01/04 17:09:23]

Done.  Actually |uses_ppapi| is also toggled to false for PNaCl, so I'm not sure
how temporary that is.  It may hang around until the nacl trusted plugin logic
is rewritten?

+                             [in] PP_Bool uses_irt,
                              [out] mem_t imc_handles);
 
   /* This function starts the IPC proxy so the nexe can communicate with the
    * browser. Returns PP_NACL_OK on success, otherwise a result code indicating
    * the failure. PP_NACL_FAILED is returned if LaunchSelLdr wasn't called with
    * the instance. PP_NACL_ERROR_MODULE is returned if the module can't be
    * initialized. PP_NACL_ERROR_INSTANCE is returned if the instance can't be
    * initialized. PP_NACL_USE_SRPC is returned if the plugin should use SRPC.
    */
   PP_NaClResult StartPpapiProxy(PP_Instance instance);
@@ skipping 43 matching lines @@
   PP_Bool IsOffTheRecord();
 
   /* Return true if PNaCl is turned on.
    */
   PP_Bool IsPnaclEnabled();
 
   /* Display a UI message to the user. */
   PP_NaClResult ReportNaClError([in] PP_Instance instance,
                                 [in] PP_NaClError message_id);
 };