Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1176073003: Improve filtering quality of images downsampled in 2d canvas (Closed)

Created:
5 years, 6 months ago by Justin Novosad
Modified:
5 years, 6 months ago
Reviewers:
Stephen White
CC:
blink-reviews, dshwang, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve filtering quality of images downsampled in 2d canvas With this change, images that are downsampled with drawImage on a 2D canvas will use mipmapping in order to produce higher quality results. non-downsampled images will continue to use bilerp, so performance should not be impacted in majority of use cases. BUG=498356 TEST=fast/canvas/downsample-quality.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197217

Patch Set 1 #

Patch Set 2 : added NeedsRebaseline #

Patch Set 3 : re-add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/downsample-quality.html View 2 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Justin Novosad
PTAL
5 years, 6 months ago (2015-06-10 20:48:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176073003/1
5 years, 6 months ago (2015-06-16 18:39:53 UTC) #4
Justin Novosad
Senorblanco: Review ping
5 years, 6 months ago (2015-06-16 19:43:46 UTC) #5
Stephen White
LGTM
5 years, 6 months ago (2015-06-16 20:13:55 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59118)
5 years, 6 months ago (2015-06-16 20:50:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176073003/40001
5 years, 6 months ago (2015-06-16 23:23:52 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 00:46:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197217

Powered by Google App Engine
This is Rietveld 408576698